904684 - Long pressing on non-suggestion part of search engine row should offer search management options

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

Yay! more context menu stuff!

We should offer some rudimentary search engine managment in the awesomescreen. i.e. long tapping an engine should offer "Remove", "Set as default", and "Get suggestions" options.

Comment 1

[:Margaret Leibovic]

I think this sounds like a good idea to me, I wonder what ibarlow thinks.

This could be a good mentor bug, the logic for these things is already in browser.js, we'd just need to send the right messages from Java.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

I kinda disagree with the "non-suggestion part" of the row. That is too tricksy for uses to get right. If we do this, I think we need to do it for the entire row. Unless we have a good argument for "non-suggestion part" only.

Comment 3

[Wesley Johnston (:wesj)]

My main thinking there was that long-tapping on suggestions current puts them in the urlbar, which is handy (we then find new suggestions under your finger, which is confusing and makes it scary to lift your finger... different bug though).

If we wanted to retain that ability in a less un-discoverable fashion, we could consider adding an icon on the left of the suggestion though (similar to what chrome does...). I've wondered if maybe we should actually have a "3-dots" menu type icon on the rows anyway, to bring up the context menu options. Again, separate bugs...

Comment 4

[Sriram Ramasubramanian [:sriram]]

(In reply to Wesley Johnston (:wesj) from comment #3)
> My main thinking there was that long-tapping on suggestions current puts
> them in the urlbar, which is handy (we then find new suggestions under your
> finger, which is confusing and makes it scary to lift your finger...
> different bug though).
> 
> If we wanted to retain that ability in a less un-discoverable fashion, we
> could consider adding an icon on the left of the suggestion though (similar
> to what chrome does...). I've wondered if maybe we should actually have a
> "3-dots" menu type icon on the rows anyway, to bring up the context menu
> options. Again, separate bugs...

Yaay! 3-dots! yaay! affordance!! yaaay! no long press!!!

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

I would be OK with using the "3 dot" menu icon in places where the affordance would help. I see other apps using this menu in various parts of their UIs. Mainly in tile-based UIs but also in some lists too.

As with anything, I'd suggest we use it sparingly.

Comment 6

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.