Long pressing on non-suggestion part of search engine row should offer search management options

NEW
Unassigned

Status

()

6 years ago
5 years ago

People

(Reporter: wesj, Unassigned)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
Yay! more context menu stuff!

We should offer some rudimentary search engine managment in the awesomescreen. i.e. long tapping an engine should offer "Remove", "Set as default", and "Get suggestions" options.
I think this sounds like a good idea to me, I wonder what ibarlow thinks.

This could be a good mentor bug, the logic for these things is already in browser.js, we'd just need to send the right messages from Java.
Flags: needinfo?(ibarlow)
I kinda disagree with the "non-suggestion part" of the row. That is too tricksy for uses to get right. If we do this, I think we need to do it for the entire row. Unless we have a good argument for "non-suggestion part" only.
(Reporter)

Comment 3

6 years ago
My main thinking there was that long-tapping on suggestions current puts them in the urlbar, which is handy (we then find new suggestions under your finger, which is confusing and makes it scary to lift your finger... different bug though).

If we wanted to retain that ability in a less un-discoverable fashion, we could consider adding an icon on the left of the suggestion though (similar to what chrome does...). I've wondered if maybe we should actually have a "3-dots" menu type icon on the rows anyway, to bring up the context menu options. Again, separate bugs...
(In reply to Wesley Johnston (:wesj) from comment #3)
> My main thinking there was that long-tapping on suggestions current puts
> them in the urlbar, which is handy (we then find new suggestions under your
> finger, which is confusing and makes it scary to lift your finger...
> different bug though).
> 
> If we wanted to retain that ability in a less un-discoverable fashion, we
> could consider adding an icon on the left of the suggestion though (similar
> to what chrome does...). I've wondered if maybe we should actually have a
> "3-dots" menu type icon on the rows anyway, to bring up the context menu
> options. Again, separate bugs...

Yaay! 3-dots! yaay! affordance!! yaaay! no long press!!!
I would be OK with using the "3 dot" menu icon in places where the affordance would help. I see other apps using this menu in various parts of their UIs. Mainly in tile-based UIs but also in some lists too.

As with anything, I'd suggest we use it sparingly.
Flags: needinfo?(ibarlow)
You need to log in before you can comment on or make changes to this bug.