Closed
Bug 904823
Opened 12 years ago
Closed 12 years ago
Encourage xpcshell make target users to use mach
Categories
(Testing :: XPCShell Harness, defect)
Testing
XPCShell Harness
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: gps, Assigned: gps)
Details
Attachments
(1 file)
|
6.69 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We want to encourage people to use mach over make for running xpcshell tests. Let's have the make targets print a message encouraging people to do this before we fully deprecate the make targets.
|
Assignee | |
Comment 1•12 years ago
|
||
Just added some warnings. I intentially kept the verbage casual.
Attachment #789800 -
Flags: review?(ted)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → gps
|
||
Comment 2•12 years ago
|
||
Comment on attachment 789800 [details] [diff] [review]
Discourage use of make for running xpcshell tests
Review of attachment 789800 [details] [diff] [review]:
-----------------------------------------------------------------
Sort of an odd way to use $(warning), since that prints at evaluation time and not execution time, but I guess it doesn't really matter.
Attachment #789800 -
Flags: review?(ted) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Oops, I forgot $(warning) was evaluation time. I'll switch to $(info).
|
|
Assignee | |
Comment 4•12 years ago
|
||
Flags: in-testsuite-
|
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•