Remove tab-clip-path-outer for the new tab button

RESOLVED FIXED in Firefox 28

Status

()

Firefox
Theme
RESOLVED FIXED
5 years ago
a year ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

({perf})

Trunk
Firefox 28
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [Australis:M8])

Attachments

(1 attachment)

Created attachment 789896 [details] [diff] [review]
v.1 - No new tab button clip-path

The new tab button's clip path seems to account for ~10% of TART frame interval differences on my XP single-core VM with HWA off.

We can probably remove the clip-path and do one of the following:
1) fix the layering of the button compared to the tabs
2) accept an incorrect hover/clickable area
3) use a rectangular pointer-event region (without clip-path) using another element.

I don't know how feasible each of these options are.
Comment on attachment 789896 [details] [diff] [review]
v.1 - No new tab button clip-path

Actually, it seems like this patch has the same behaviour (for which area you can hover over) as background tabs so I think we can just land this.

This actually shows potentially large wins on ts_paint http://compare-talos.mattn.ca/index.html?oldRevs=d69fa7f94f40&newRev=2b3adc222e4c&submit=true
Attachment #789896 - Flags: review?(jaws)
Attachment #789896 - Attachment description: WIP 1 - No new tab button clip-path. ntb overlaps last tab → v.1 - No new tab button clip-path
Comment on attachment 789896 [details] [diff] [review]
v.1 - No new tab button clip-path

Review of attachment 789896 [details] [diff] [review]:
-----------------------------------------------------------------

Tested it and it works good.
Attachment #789896 - Flags: review?(jaws) → review+
Fab, as the British would say!

Have we looked at not adding clip paths to the tabs until after the animation finishes?
(In reply to :Gijs Kruitbosch from comment #4)
> Have we looked at not adding clip paths to the tabs until after the
> animation finishes?

As discussed on IRC, the other uses of clip-path actually clip the background and gradients unlike this one which was only used for the pointer-events.

Updated

5 years ago
Summary: tab-clip-path-outer for the new tab button could possibly be removed → Remove tab-clip-path-outer for the new tab button
https://hg.mozilla.org/mozilla-central/rev/af9924226bb0
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.