Closed Bug 904953 Opened 6 years ago Closed 6 years ago

Intermittent devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up.

Categories

(DevTools :: Inspector, defect)

All
macOS
defect
Not set

Tracking

(firefox24 unaffected, firefox25 unaffected, firefox26 fixed, firefox27 unaffected, firefox28 unaffected, firefox29 fixed, firefox30 fixed, firefox-esr24 unaffected)

RESOLVED FIXED
Firefox 30
Tracking Status
firefox24 --- unaffected
firefox25 --- unaffected
firefox26 --- fixed
firefox27 --- unaffected
firefox28 --- unaffected
firefox29 --- fixed
firefox30 --- fixed
firefox-esr24 --- unaffected

People

(Reporter: KWierso, Assigned: pbro)

Details

(Keywords: intermittent-failure, Whiteboard: [qa-])

Attachments

(2 files, 3 obsolete files)

https://tbpl.mozilla.org/php/getParsedLog.php?id=26512413&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
This is currently the #1 top orange on m-c. Can one of you please look into this?
Flags: needinfo?(bgrinstead)
Attached patch test-timeout-904953.patch (obsolete) — Splinter Review
Unless if you can think of an easy way to refactor this into multiple tests without copying/pasting code, I think requesting a longer timeout is the best way to handle this.
Attachment #794968 - Flags: review?(mratcliffe)
Flags: needinfo?(bgrinstead)
Assignee: nobody → bgrinstead
Comment on attachment 794968 [details] [diff] [review]
test-timeout-904953.patch

Review of attachment 794968 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/markupview/test/browser_inspector_markup_edit.js
@@ +21,5 @@
>    let {
>      getInplaceEditorForSpan: inplaceEditor
>    } = devtools.require("devtools/shared/inplace-editor");
>  
> +  requestLongerTimeout(2);

r+ if you add a comment explaining why we need to do this.
Attachment #794968 - Flags: review?(mratcliffe) → review+
Status: NEW → ASSIGNED
Updated with comment
Attachment #794968 - Attachment is obsolete: true
Attachment #795380 - Flags: review+
Can you please land this in fx-team?
Flags: needinfo?(mratcliffe)
Whiteboard: [land-in-fx-team]
That's what checkin-needed is for :)
Flags: needinfo?(mratcliffe)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/830b27fcb066
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
seems this problem still occur, so is it really fixed ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestL → Intermittent devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up.
Attachment #795380 - Flags: checkin+