Intermittent devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up.

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools: Inspector
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: KWierso, Assigned: pbro)

Tracking

({intermittent-failure})

Trunk
Firefox 30
All
Mac OS X
intermittent-failure
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox24 unaffected, firefox25 unaffected, firefox26 fixed, firefox27 unaffected, firefox28 unaffected, firefox29 fixed, firefox30 fixed, firefox-esr24 unaffected)

Details

(Whiteboard: [qa-])

Attachments

(2 attachments, 3 obsolete attachments)

(Reporter)

Description

5 years ago
https://tbpl.mozilla.org/php/getParsedLog.php?id=26512413&tree=Fx-Team

TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
This is currently the #1 top orange on m-c. Can one of you please look into this?
Flags: needinfo?(bgrinstead)
Created attachment 794968 [details] [diff] [review]
test-timeout-904953.patch

Unless if you can think of an easy way to refactor this into multiple tests without copying/pasting code, I think requesting a longer timeout is the best way to handle this.
Attachment #794968 - Flags: review?(mratcliffe)
Flags: needinfo?(bgrinstead)
Assignee: nobody → bgrinstead
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment on attachment 794968 [details] [diff] [review]
test-timeout-904953.patch

Review of attachment 794968 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/markupview/test/browser_inspector_markup_edit.js
@@ +21,5 @@
>    let {
>      getInplaceEditorForSpan: inplaceEditor
>    } = devtools.require("devtools/shared/inplace-editor");
>  
> +  requestLongerTimeout(2);

r+ if you add a comment explaining why we need to do this.
Attachment #794968 - Flags: review?(mratcliffe) → review+
Status: NEW → ASSIGNED
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Created attachment 795380 [details] [diff] [review]
test-timeout-904953.patch

Updated with comment
Attachment #794968 - Attachment is obsolete: true
Attachment #795380 - Flags: review+
Can you please land this in fx-team?
Flags: needinfo?(mratcliffe)
Whiteboard: [land-in-fx-team]
That's what checkin-needed is for :)
Flags: needinfo?(mratcliffe)
Keywords: checkin-needed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Keywords: checkin-needed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
https://hg.mozilla.org/mozilla-central/rev/830b27fcb066
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Comment hidden (Treeherder Robot)
status-firefox24: --- → unaffected
status-firefox25: --- → unaffected
status-firefox26: --- → fixed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
seems this problem still occur, so is it really fixed ?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

5 years ago
status-firefox24: --- → unaffected
status-firefox25: --- → unaffected
status-firefox26: --- → fixed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)

Updated

5 years ago
Summary: Intermittent TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestL → Intermittent devtools/markupview/test/browser_inspector_markup_edit.js | This test exceeded the timeout threshold. It should be rewritten or split up.
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Attachment #795380 - Flags: checkin+
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Disabled on Linux for frequent failures.
https://hg.mozilla.org/integration/fx-team/rev/8d4aba2565c9
Whiteboard: [test disabled on Linux][leave open]
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 352

4 years ago
I'm taking a look at this test since it shows up in the first 20 orange factor entries.
I wonder if the change to exclude it made in comment 341 was really done?

Brian: it seems to me that addAttributes, editTagName and removeElementWithDelete are functions that are executed after the whole edits array tests are run. They look like good candidates to split away in their own test files.

Also, if we extracted the various attribute assertion and edition functions to head.js, we would then be able to split the edits array between several test files without having to duplicate much code.

I may take a look at this bug if you're not working on it now, that would give me a good opportunity to do some of the changes described in bug 968727.
Flags: needinfo?(bgrinstead)
(Assignee)

Updated

4 years ago
Assignee: bgrinstead → pbrosset
status-firefox29: --- → disabled
status-firefox30: --- → disabled
(Assignee)

Comment 354

4 years ago
(In reply to Patrick Brosset [:pbrosset] [:patrick] from comment #352)
> I'm taking a look at this test since it shows up in the first 20 orange
> factor entries.
> I wonder if the change to exclude it made in comment 341 was really done?
Yes turns out it was, I just didn't know how to read browser.ini files.
The test failures since then were on aurora since the test was only skipped on inbound branches.
As comment 353 suggests, it's now skipped on Aurora too.

I now have a new patch for this that splits this test in 5 parts.
There is still 1 part that's relatively big, but looking at the code there's not much sense splitting it further, at least for now.
I'll launch try builds and see if works better.
(Assignee)

Comment 355

4 years ago
Created attachment 8373402 [details] [diff] [review]
bug904953-intermittent-markup-edit-test.patch

This test takes too long to run, and intermittently fails on linux debug platforms.
This patch splits it in 5 and removes the skip-if condition in browser.ini
Here's an ongoing try build: https://tbpl.mozilla.org/?tree=Try&rev=5f069cdf4797 which I'll use to launch a series of bc tests.
Attachment #8373402 - Flags: review?(jwalker)
Flags: needinfo?(bgrinstead)
Comment hidden (Treeherder Robot)
(Assignee)

Comment 357

4 years ago
The try build showed that one of the 5 parts still fails intermittently on Linux debug platforms.
That part is the attribute addition test which iterates over an array of 17 testcases and for each of them, creates a div, adds the test attribute string, asserts that the attributes were parsed and added correctly, and undoes the change.
I've rewritten the test and relaunched a new try build: https://tbpl.mozilla.org/?tree=Try&rev=125feb05d464
(Assignee)

Comment 358

4 years ago
Comment on attachment 8373402 [details] [diff] [review]
bug904953-intermittent-markup-edit-test.patch

Canceling the review request for now, until try builds are green.
Attachment #8373402 - Flags: review?(jwalker)
(Assignee)

Comment 359

4 years ago
Created attachment 8374032 [details] [diff] [review]
bug904953-intermittent-markup-edit-test v2.patch

The last try build https://tbpl.mozilla.org/?tree=Try&rev=125feb05d464 seems to show that the intermittent is gone!

To summarize, this patch splits the test file in 5 test files and rewrites the 4 new parts:
- browser_inspector_markup_add_attributes.js: this is the part that was still running for too long in the previous try build. Rewritten and simplified.
- browser_inspector_markup_edit2/3/4.js: these tests verify that existing attributes can be changed, tagnames can be modified and nodes can be deleted. They've all been rewritten too.
Attachment #8373402 - Attachment is obsolete: true
Attachment #8374032 - Flags: review?(jwalker)
Comment on attachment 8374032 [details] [diff] [review]
bug904953-intermittent-markup-edit-test v2.patch

Review of attachment 8374032 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/markupview/test/browser_inspector_markup_add_attributes.js
@@ +170,5 @@
> +  }).then(null, ok.bind(null, false)).then(finishUp);
> +}
> +
> +function finishUp() {
> +  doc = inspector = markup = null;

If you make these non-global (i.e. local to the Task.spawn function) then you won't need to clear them up, and the removeCurrentTab() could go in the same place, removing 3 globals and one extra function.

::: browser/devtools/markupview/test/browser_inspector_markup_edit.js
@@ +32,4 @@
>  
> +let TEST_DATA = [
> +  {
> +    desc: "Change an attribute",

I know this isn't new, but +1 for the 'desc' property. I like it.

::: browser/devtools/markupview/test/head.js
@@ +63,5 @@
> + * and open the inspector
> + * @param {String} url The url to be loaded in the new tab
> + * @return a promise that resolves when the inspector is ready
> + */
> +function addTabAndOpenInspector(url) {

I wonder if we need addTabAndOpenInspector(url) when it's the same as saying addTab(url).then(openInspector)
?

@@ +190,5 @@
> +function setEditableFieldValue(field, value, inspector) {
> +  field.focus();
> +  EventUtils.sendKey("return", inspector.panelWin);
> +  let input = inplaceEditor(field).input;
> +  ok(input, "An editable field was found and activated");

I've always tried to keep my assert messages unique (ish) to help people work out where things went wrong. It's probably not worth going back, but might be worth thinking about another time.
Attachment #8374032 - Flags: review?(jwalker) → review+
(Assignee)

Comment 361

4 years ago
Created attachment 8374137 [details] [diff] [review]
bug904953-intermittent-markup-edit-test v3.patch

Thanks for the review.
This patch addresses your comments.
Attachment #8374032 - Attachment is obsolete: true
Attachment #8374137 - Flags: review?(jwalker)
Attachment #8374137 - Flags: review?(jwalker) → review+
(Assignee)

Comment 362

4 years ago
Here's the current status:

- the last patch attached seems to resolves the intermittent failure during linux debug builds: https://tbpl.mozilla.org/?tree=Try&rev=125feb05d464
- a new try build was launch on all platforms: https://tbpl.mozilla.org/?tree=Try&rev=5a6de62885dd
- the patch is R+
- the patch splits the long running test into several parts AND removes the `skip-if` condition that was added.

As soon as the last try build is green, I'll land this.
Flags: needinfo?(ryanvm)
(Assignee)

Comment 363

4 years ago
Try build is green.
Landing this in fx-team: https://hg.mozilla.org/integration/fx-team/rev/e30953666622
Whiteboard: [test disabled on Linux][leave open] → [test disabled on Linux][leave open][fixed-in-fx-team]
Flags: needinfo?(ryanvm)
Whiteboard: [test disabled on Linux][leave open][fixed-in-fx-team] → [fixed-in-fx-team]
(Reporter)

Comment 364

4 years ago
https://hg.mozilla.org/mozilla-central/rev/e30953666622
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago4 years ago
Flags: in-testsuite- → in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: Firefox 26 → Firefox 30
status-firefox28: --- → unaffected
status-firefox30: disabled → fixed
status-firefox-esr24: --- → unaffected

Updated

4 years ago
Whiteboard: [qa-]
(Assignee)

Comment 365

4 years ago
Comment on attachment 8374137 [details] [diff] [review]
bug904953-intermittent-markup-edit-test v3.patch

[Approval Request Comment]

Bug caused by (feature/regressing bug #): 
Note that this bug is only about test files and the only reason why I'd like it uplifted is so that bug 962647 can be uplifted to Aurora without merging.


User impact if declined: 
If declined, bug 962647 can't be uplifted to Aurora.

Testing completed (on m-c, etc.): 
This is a test-only patch, which has been on m-c for more than 2 weeks and resolved an intermittent orange.

Risk to taking this patch (and alternatives if risky): 
Risk is limited as this is a test-only patch.

String or IDL/UUID changes made by this patch:
Attachment #8374137 - Flags: approval-mozilla-aurora?
Attachment #8374137 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/06109f5751f5
status-firefox27: --- → unaffected
status-firefox29: disabled → fixed
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)
Comment hidden (Treeherder Robot)