904982 - [System] System reboot if CustomDialog shows with improper callbacks

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

STR:

1. Show the dialog with callbacks contain no 'CustomDialog.hide()', ex: `CustomDialog.show('Title', 'Message', function(){}, function(){})` .

2. The dialog pop-up, and then press the cancel or confirm button. 

Expected Results:  
Nothing happens. Because callbacks do no-op.

Actual Results:  
System reboot.

Tested on:
1. Firefox Nightly 26.0a1 + Gaia profile at Linux x86_64
2. B2G 1.1.0-prerelease, unagi/1.1.0/beta

----

I don't know the principle of handling such callbacks, but I think that if the callbacks are really improper, it at least should throw exceptions instead reboot the whole system.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

(In reply to Greg Weng [:snowmantw] from comment #0)

Sorry, the callbacks in the example are wrong. It should be:
CustomDialog.show('Title', 'Message', 
{'title': 'Cancel', 'callback': function(){} }, 
{'title': 'Confirm', 'callback': function(){} })

> STR:
> 
> 1. Show the dialog with callbacks contain no 'CustomDialog.hide()', ex:
> `CustomDialog.show('Title', 'Message', function(){}, function(){})` .
> 
> 2. The dialog pop-up, and then press the cancel or confirm button. 
> 
> Expected Results:  
> Nothing happens. Because callbacks do no-op.
> 
> Actual Results:  
> System reboot.
> 
> Tested on:
> 1. Firefox Nightly 26.0a1 + Gaia profile at Linux x86_64
> 2. B2G 1.1.0-prerelease, unagi/1.1.0/beta
> 
> ----
> 
> I don't know the principle of handling such callbacks, but I think that if
> the callbacks are really improper, it at least should throw exceptions
> instead reboot the whole system.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

After tests, I've found that the "button" tag is default to submit the form, and then the page will get refreshed as the browser's default behavior. At least after I added the "type=button" attribute on the element, it never reboot again.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

It's caused by the default type of a element will be 'Submit', and the Gecko will reload whole system app as browser reloading the page. Solved this after setting correct type to the buttons.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 790660 [details]
Patch

r=me if you correct the comments.
BTW, if this affects v1-train as well, please set |leo?| flag.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Than(In reply to Alive Kuo [:alive] from comment #4)
> Comment on attachment 790660 [details]
> Patch
> 
> r=me if you correct the comments.
> BTW, if this affects v1-train as well, please set |leo?| flag.

Thanks for reviewing, and I still have no permission to merge in GitHub, so please merge for me.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

master
https://github.com/mozilla-b2g/gaia/commit/7ca2728938944150cbf30ef1c1cba6e20772a720