[Clock] Switching from Alarm Edit back to Clock with "Done" may lose the display

RESOLVED FIXED

Status

Firefox OS
Gaia::Clock
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: rwaldron, Assigned: rwaldron)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
iliu@mozilla.com, ianliu.moz@gmail.com
: review+
Details | Review | Splinter Review
(Assignee)

Description

5 years ago
As reported during the review of #882751


After some clarification, I can repro.

- Use "Done" to close quickly and repeat
- Display may dissappear


https://bugzilla.mozilla.org/show_bug.cgi?id=882751#c6
(Assignee)

Updated

5 years ago
Assignee: nobody → waldron.rick
(Assignee)

Comment 1

5 years ago
Created attachment 790993 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11561

- Store a timeout for hide's deferred class removal operation
- If the timeout occurs and is not cleared, clear the timeout and proceed with operation
- If show is called before hide's timeout is cleared, clear the timeout and cancel the operation
Attachment #790993 - Flags: review?(iliu)
Comment on attachment 790993 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11561

The patch works for me. Thanks.
Attachment #790993 - Flags: review?(iliu) → review+
(Assignee)

Comment 3

5 years ago
gaia@master https://github.com/mozilla-b2g/gaia/commit/9d02f4a3b6631c0e1b2609887f3796ad1ddb7608
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.