Closed Bug 904990 Opened 9 years ago Closed 9 years ago

[Clock] Switching from Alarm Edit back to Clock with "Done" may lose the display

Categories

(Firefox OS Graveyard :: Gaia::Clock, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Clock
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rwaldron, Assigned: rwaldron)

Details

Attachments

(1 file)

https://github.com/mozilla-b2g/gaia/pull/11561
46 bytes, text/x-github-pull-request
iliu
: review+
Details | Review 
As reported during the review of #882751


After some clarification, I can repro.

- Use "Done" to close quickly and repeat
- Display may dissappear


https://bugzilla.mozilla.org/show_bug.cgi?id=882751#c6
Assignee: nobody → waldron.rick
- Store a timeout for hide's deferred class removal operation
- If the timeout occurs and is not cleared, clear the timeout and proceed with operation
- If show is called before hide's timeout is cleared, clear the timeout and cancel the operation
Attachment #790993 - Flags: review?(iliu)
Comment on attachment 790993 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11561

The patch works for me. Thanks.
Attachment #790993 - Flags: review?(iliu) → review+
gaia@master https://github.com/mozilla-b2g/gaia/commit/9d02f4a3b6631c0e1b2609887f3796ad1ddb7608
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.