Hide build status markers when not building with mach

RESOLVED FIXED in mozilla26

Status

()

Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

24 Branch
mozilla26
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
The BUILDSTATUS messages are distracting in non-mach builds. Let's just hide them.
(Assignee)

Comment 1

4 years ago
Created attachment 790095 [details] [diff] [review]
Hide build status markers when not building with mach
Attachment #790095 - Flags: review?(gps)
(Assignee)

Updated

4 years ago
Assignee: nobody → mh+mozilla
Comment on attachment 790095 [details] [diff] [review]
Hide build status markers when not building with mach

Review of attachment 790095 [details] [diff] [review]:
-----------------------------------------------------------------

Bug 901601 would have also hidden these status messages (at least for client.mk builds). But, this is fine.

::: python/mozbuild/mozbuild/base.py
@@ +380,5 @@
>          if srcdir:
>              fn = self._run_command_in_srcdir
>  
> +        append_env = dict(append_env or ())
> +        append_env['MACH'] = '1'

I think we need b'' strings here lest older Pythons complain about unicode strings in env.
Attachment #790095 - Flags: review?(gps) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b83621ceedf
https://hg.mozilla.org/mozilla-central/rev/4b83621ceedf
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.