Closed Bug 905089 Opened 11 years ago Closed 11 years ago

[messages] remove the unused and dangerous WaitingScreen.update function

Categories

(Firefox OS Graveyard :: Gaia::SMS, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::SMS
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

References

(
URL
)

Details

Attachments

(1 file)

patch v1
951 bytes, patch
borjasalguero
: review+
Details | Diff | Splinter Review 
From https://wiki.mozilla.org/Security/Reviews/Gaia/sms#1._XSS_.26_HTML_Injection_attacks, we should remove that unused and dangerous function.
Attached patch patch v1 — — Splinter Review 
github PR https://github.com/mozilla-b2g/gaia/pull/11959

this is lying here since too long, I got bored.
Assignee: nobody → felash
Attachment #800229 - Flags: review?(fbsc)
Comment on attachment 800229 [details] [diff] [review]
patch v1

Review of attachment 800229 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Julien for the patch!
Attachment #800229 - Flags: review?(fbsc) → review+
master: 6d3fe621d52a48fcbb282fe756d2c1aa21277b9a

thanks borja !
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: