90512 - 2 missing files from embed-win32.zip

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[Aaron Leventhal]

In order for screen readers, screen magnifiers and voice dictation packages to
have the proper hooks into Mozilla, we support the Microsoft Active
Accessibility (MSAA) API. We also support our own SimpleDOM API for getting to
actual content from out of process. These API's are documented at
http://www.mozilla.org/projects/ui/accessibility/vendors-win.html

These 2 files must be added in the components directory:
accessibility.dll
accessibility.xpt

Not necessary on other systems except win32.

Comment 1

[Aaron Leventhal]

Attachment: Patch

Comment 2

[Judson Valeski]

patch looks good to me. r=valeski.

Please run make in the config dir, then goto dist/*/Embed and run mfcEmbed from
there. hit the smoketests please
http://www.mozilla.org/quality/smoketests/embed-basic-test.html

Comment 3

[Aaron Leventhal]

I did run into problems with the smoketests on items EM 7 and EM 8.
Filed bug 91160 and bug 91161 for those problems.

However, this appears to be like the scroll bar problem (bug 90707).
They're problems with MFCEMBED, not with my patch.
accessibility.dll has been in the trunk for some time, and it's part of the
Netscape 6 install - so it's known to work.

Jud, does your r= still stand?

Comment 4

[Judson Valeski]

sounds good. thanks for smoketesting. r=valeski

Comment 5

[Chris Waterson]

sr=waterson

Comment 6

[Aaron Leventhal]

Fix checked in.

Comment 7

[Aaron Leventhal]

The files are listed in basebrowser-win

but somehow they don't make it into 
http://ftp.mozilla.org/pub/mozilla/nightly/latest/embed-win32.zip

What gives?

Comment 8

[Aaron Leventhal]

Nevermind, fix wasn't correctly checked in first time.

Comment 9

[dsirnapalli]

-- Verified in latest embed.win32.zip. 
The two files are added in components folder.
accessibility.dll
accessibility.xpt

Marking the bug as verified.