905136 - Blackbox icons missing from debugger (Linux)

Status: VERIFIED FIXED

(DevTools :: Debugger, defect)

Description

[Geoff Lankow (:darktrojan)]

It just shows checkboxes. The checkbox binding is different under Linux so the CSS doesn't apply properly. I'll confirm this is the cause once my tree is working again.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 905136-1.diff

This fixes the problem, but there's still a stray focus rectangle of about 3px x 3px.

Comment 2

[Girish Sharma [:Optimizer]]

image ?
That must be the work of border. You might need border: none !important;

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: Focus rectangle shown after fix

This is just bug 669507 striking again. Someone should fix that.

Comment 4

[Alex Keybl [:akeybl]]

I'm not sure what I'm looking at, so I'll ask dcamp :)

Is this critical enough to track for release?

Comment 5

[Dave Camp (:dcamp)]

Yeah, please track this for release.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Can we retest this after bug 905046 lands in m-c?

Comment 7

[Geoff Lankow (:darktrojan)]

Not a dupe, the CSS selectors need to be changed in the Linux theme.
(Tested on Nightly just to make sure.)

Comment 8

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 790184 [details] [diff] [review]
905136-1.diff

Hmmmm, patch doesn't apply for me on fx-team.

I don't have a linux box handy, maybe Mihai can be your reviewer?

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: 905136-2.diff

(In reply to Nick Fitzgerald [:fitzgen] from comment #8)
> Comment on attachment 790184 [details] [diff] [review]
> 905136-1.diff
> 
> Hmmmm, patch doesn't apply for me on fx-team.

Oh, of course it doesn't. My mistake.

Comment 10

[Mihai Sucan [:msucan]]

Comment on attachment 792532 [details] [diff] [review]
905136-2.diff

Without this patch: I see checkboxes for the blackboxing feature.

With this patch: I see the eye icon for blackboxing.

I tested on Ubuntu 12.04.

Comment 11

[Mihai Sucan [:msucan]]

Geoff: thanks for the bug report and for the fix.

Comment 12

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Thanks for reviewing Mihai :)

Comment 13

[Geoff Lankow (:darktrojan)]

https://hg.mozilla.org/integration/fx-team/rev/460f2574cbd2

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/460f2574cbd2

Comment 15

[Alex Keybl [:akeybl]]

Mihai, can you help with an uplift request to Beta 25 here?

Comment 16

[Mihai Sucan [:msucan]]

Attachment: patch for beta 25

Sure! This is the rebased patch for mozilla-beta (Firefox 25).


[Approval Request Comment]
Bug caused by (feature/regressing bug #): feature exposed by new UI in bug 877686.
User impact if declined: the icon for blackboxing sources in the JS debugger will not show for Linux users.
Testing completed (on m-c, etc.): patch landed in fx-team and m-c for some time already.
Risk to taking this patch (and alternatives if risky): minimal to none.
String or IDL/UUID changes made by this patch: none.

Thank you!

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca0a44573e42

Comment 18

[Paul Silaghi, QA [:pauly]]

Blackbox eye is functional now, but there is a small red circle near the eye, which remain displayed after turning off blackboxing. What is it for ? It's displayed only on Linux. Tested on FF 25b3, Ubuntu 13.04

Comment 19

[Geoff Lankow (:darktrojan)]

(In reply to Paul Silaghi [QA] from comment #18)
> Blackbox eye is functional now, but there is a small red circle near the
> eye, which remain displayed after turning off blackboxing. What is it for ?
> It's displayed only on Linux. Tested on FF 25b3, Ubuntu 13.04

It's the focus rectangle for the checkbox, bug 669507.

Comment 20

[Paul Silaghi, QA [:pauly]]

Verified fixed on FF 25b3 Ubuntu 13.04, based on comment 19.

Comment 21

[Paul Silaghi, QA [:pauly]]

The blackbox eye is smaller in FF 26, 27 compared to FF 25. Is it expected?

Comment 22

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Yes.

Comment 23

[Paul Silaghi, QA [:pauly]]

Verified fixed on FF 26.0a2 (2013-10-03) Ubuntu 13.04