905156 - on /about page, the h1 block displayed as a red box should have a min-width not a width, for locales

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect, P3)

Description

[Pascal Chevrel:pascalc]

https://www-dev.allizom.org/fr/about/

The red strip at the top has a width:420px at the top, this is inherited from about-base.less

I think it should be min-width:420px instead as it would allow longer text to not be on 2 lines but it might be a fixed width because of mobile.

CCing Steven, Steven can we just change width to min-width?

Comment 1

[Alex Gibson [:agibson]]

Only IE 6/7 do not support `min-width` (http://caniuse.com/#search=min-width), but we should be fine to use it here as long as we specify a suitable percentage based `width` value as a fallback for those browsers.

Comment 2

[Alex Gibson [:agibson]]

PR opened here:

https://github.com/mozilla/bedrock/pull/1232

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/32ac094289c82e9066881e4e13f8b3b9e5a7b438
[fix bug 905156] About page h1 should have a min-width

https://github.com/mozilla/bedrock/commit/376911802d6dc3e8512750cc122d335e3a9b2b20
Merge pull request #1232 from alexgibson/bug-905156-use-min-width-on-h1-for-about-page-locales

[fix bug 905156] About page h1 should have a min-width

Comment 4

[raymond [:retornam] (inactive)]

fixed on stage https://www.allizom.org/fr/about/

Comment 5

[raymond [:retornam] (inactive)]

verified fixed

https://www.mozilla.org/fr/about/