90520 - ^M in nsSecureBrowserUIImpl.cpp:340 breaks IRIX build

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Chris McAfee]

windows CRLF ^M in mozilla/security/manager/ssl/srcnsSecureBrowserUIImpl.cpp:340
breaks IRIX build, this was accidentally checked in as part of the 1.19
checkin for this file.

Comment 1

[Jesse Ruderman]

How does one avoid checking in ^M's?  Is cvs commit supposed to strip them out
automatically?

Comment 2

[timeless]

using wincvs on windows, or making sure not to have them already when 
committing from unix (dos2unix [if avail] will remove them, as can various 
other things in emacs, perl, sed, vi)

but what would really help is if people would report correct cvs paths. (arg!)

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/security/manager/ssl/src/ns
SecureBrowserUIImpl.cpp&rev=1.19&mark=340#340

Is there a reason this bug is still open?

1.20 ddrinan%netscape.com Jul 12 11:44 Remove ^M that was accidentially checked 
in.

It's a good thing people don't care that we misspell checkin comments (i did it 
yesterday or the day before), >accidentally<

this problem is no longer the reason for irix being red.

Comment 3

[John Unruh]

Verified per timeless' comment.

Comment 4

[John Unruh]

Mass changing Security:Crypto to PSM

Comment 5

[John Unruh]

Mass changing Security:Crypto to PSM