905219 - Change BaseRect::IsFinite() to use std::isfinite rather than NS_finite

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

+++ This bug was initially created as a clone of Bug #903526 +++

Change BaseRect::IsFinite() to use std::isfinite rather than NS_isfinite.  See https://bugzilla.mozilla.org/show_bug.cgi?id=903526#c13

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Use std::isfinite instead of NS_finite in BaseRect::IsFinite

Use std::isfinite instead of NS_finite to avoid dragging xpcom into gfx/2d code.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/417918b47df2

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/417918b47df2

Comment 4

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 790290 [details] [diff] [review]
Use std::isfinite instead of NS_finite in BaseRect::IsFinite

[Approval Request Comment]
See bug 913614 which is approved for uplift - this bug blocks it.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e7fbc267ac5c

Comment 6

[u279076]

Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.