All users were logged out of Bugzilla on October 13th, 2018

Change BaseRect::IsFinite() to use std::isfinite rather than NS_finite

RESOLVED FIXED in Firefox 25

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: milan, Assigned: milan)

Tracking

unspecified
mozilla26
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox25 fixed, firefox26 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #903526 +++

Change BaseRect::IsFinite() to use std::isfinite rather than NS_isfinite.  See https://bugzilla.mozilla.org/show_bug.cgi?id=903526#c13
Summary: Change BaseRect::IsFinite() to use std::isfinite rather than NS_isfinite → Change BaseRect::IsFinite() to use std::isfinite rather than NS_finite
Created attachment 790290 [details] [diff] [review]
Use std::isfinite instead of NS_finite in BaseRect::IsFinite

Use std::isfinite instead of NS_finite to avoid dragging xpcom into gfx/2d code.
Attachment #790290 - Flags: review?(jmuizelaar)
Attachment #790290 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/417918b47df2
Assignee: nobody → milan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/417918b47df2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment on attachment 790290 [details] [diff] [review]
Use std::isfinite instead of NS_finite in BaseRect::IsFinite

[Approval Request Comment]
See bug 913614 which is approved for uplift - this bug blocks it.
Attachment #790290 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #790290 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/e7fbc267ac5c
status-firefox25: --- → fixed
status-firefox26: --- → fixed
Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.