Closed Bug 905219 Opened 6 years ago Closed 6 years ago

Change BaseRect::IsFinite() to use std::isfinite rather than NS_finite

Categories

(Core :: Graphics, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: milan, Assigned: milan)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #903526 +++

Change BaseRect::IsFinite() to use std::isfinite rather than NS_isfinite.  See https://bugzilla.mozilla.org/show_bug.cgi?id=903526#c13
Summary: Change BaseRect::IsFinite() to use std::isfinite rather than NS_isfinite → Change BaseRect::IsFinite() to use std::isfinite rather than NS_finite
Use std::isfinite instead of NS_finite to avoid dragging xpcom into gfx/2d code.
Attachment #790290 - Flags: review?(jmuizelaar)
Attachment #790290 - Flags: review?(jmuizelaar) → review+
https://hg.mozilla.org/mozilla-central/rev/417918b47df2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Comment on attachment 790290 [details] [diff] [review]
Use std::isfinite instead of NS_finite in BaseRect::IsFinite

[Approval Request Comment]
See bug 913614 which is approved for uplift - this bug blocks it.
Attachment #790290 - Flags: approval-mozilla-aurora?
Attachment #790290 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assuming no verification needed here. Please add the verifyme keyword and remove the [qa-] whiteboard tag to request verification.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.