Remove guard missed after review of patch for bug 890555

RESOLVED FIXED in Firefox 26

Status

()

Firefox
Developer Tools
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: chmanchester, Assigned: chmanchester)

Tracking

unspecified
Firefox 26
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
I asked Greg to land the patches to bug 890555 for me, but neglected to upload an updated patch to respond to jimb's review comment in comment 25. So what landed included the erroneous check for undefined.
(Assignee)

Comment 1

4 years ago
Created attachment 790299 [details] [diff] [review]
Fix undefined guard missed in review for bug 890555;

This makes the change I didn't add to what landed.
Attachment #790299 - Flags: review?(jimb)
(Assignee)

Updated

4 years ago
Assignee: nobody → cmanchester

Updated

4 years ago
Attachment #790299 - Flags: review?(jimb) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Depends on: 890555
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab093985e20
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2ab093985e20
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.