Closed
Bug 905239
Opened 11 years ago
Closed 11 years ago
Remove guard missed after review of patch for bug 890555
Categories
(DevTools :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 26
People
(Reporter: chmanchester, Assigned: chmanchester)
References
Details
Attachments
(1 file)
|
1.10 KB,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
I asked Greg to land the patches to bug 890555 for me, but neglected to upload an updated patch to respond to jimb's review comment in comment 25. So what landed included the erroneous check for undefined.
|
Assignee | |
Comment 1•11 years ago
|
||
This makes the change I didn't add to what landed.
Attachment #790299 -
Flags: review?(jimb)
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → cmanchester
|
||
Updated•11 years ago
|
Attachment #790299 -
Flags: review?(jimb) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ab093985e20
Keywords: checkin-needed
|
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2ab093985e20
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•