Retire gtkEmbed test app in favor of TestGtkEmbed app. Some issues here re: running memory tests, we should try to migrate everything to TestGtkEmbed, that's working better and is a better code example.
Where/how do we get TestGtkEmbed? Any tricks--other than those already employed with gtkEmbed--to building it for leaks and reflow testing?
Do we need both a testGtkEmbed and a gtkEmbed. Since I'm not up on what the differences are I don't the answer. Can we just turn testGtkEmbed into gtkEmbed and make it transparent to our automated test scripts?
I'm not sure what's in gtkEmbed that we need to move. There are some things. Someone should make a list here.
TestGtkEmbed is now packaged in the tar file by default, is it ok from a testing standpoint to take gtkEmbed out of the tar file? I suggest we remove this in stages: 1) take gtkEmbed out of the tar file 2) stop building gtkEmbed by default 3) remove the code
request for r, sr for last patch to stop building gtkEmbed.
sr=alecf contingent upon an r/sr= from blizzard, since he owns this stuff. Should we be removing these files from the tree? i.e. is this still a good example, or does it contain hacks that we avoid showing to future embeddors?
Please let it die. I'm sick of getting email about problems with it. r/sr=blizzard
gtkEmbed is now not-built, next step is to remove the code and references to gtkEmbed.
latest patch, plus cvs removing embedding/tests/gtkEmbed should finish this off. Looking for r/sr.
Comment on attachment 54019 [details] [diff] [review] patch to remove last references to gtkEmbed r=adamlock
Comment on attachment 54019 [details] [diff] [review] patch to remove last references to gtkEmbed sr=blizzard
fixed, gtkEmbed is history now.
Verified in 10/19 mozilla nightly build. References to gtkEmbed were removed in makefiles: * removed from makefile.in * removed from allmakefiles.sh * removed from basebrowser-unix. TestGtkEmbed was added. * moz/embedding/tests/gtkEmbed removed from mk_sdk_hdr_lst.pl. "$moz/embedding/browser/gtk/tests" was added. Also, gtkEmbed is not on the tree.