Retire gtkEmbed test app in favor of TestGtkEmbed app

VERIFIED FIXED

Status

()

Core
Embedding: APIs
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Chris McAfee, Assigned: Chris McAfee)

Tracking

Trunk
x86
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
 
(Assignee)

Comment 1

17 years ago
Retire gtkEmbed test app in favor of TestGtkEmbed app.
Some issues here re: running memory tests, we should
try to migrate everything to TestGtkEmbed, that's
working better and is a better code example.

Comment 2

17 years ago
Where/how do we get TestGtkEmbed?  Any tricks--other than those already employed 
with gtkEmbed--to building it for leaks and reflow testing?

Comment 3

17 years ago
Do we need both a testGtkEmbed and a gtkEmbed.  Since I'm not up on what the 
differences are I don't the answer.  Can we just turn testGtkEmbed into gtkEmbed 
and make it transparent to our automated test scripts?
I'm not sure what's in gtkEmbed that we need to move.  There are some things. 
Someone should make a list here.

Updated

17 years ago
QA Contact: mdunn → depstein
(Assignee)

Updated

17 years ago
Depends on: 91013
(Assignee)

Updated

17 years ago
Blocks: 82141
(Assignee)

Comment 5

17 years ago
TestGtkEmbed is now packaged in the tar file by default,
is it ok from a testing standpoint to take gtkEmbed out
of the tar file?  I suggest we remove this in stages:
  1) take gtkEmbed out of the tar file
  2) stop building gtkEmbed by default
  3) remove the code
(Assignee)

Comment 6

16 years ago
Created attachment 53807 [details] [diff] [review]
patch to stop building gtkEmbed
(Assignee)

Comment 7

16 years ago
request for r, sr for last patch to stop building gtkEmbed.

Updated

16 years ago
Attachment #53807 - Flags: review+

Comment 8

16 years ago
sr=alecf contingent upon an r/sr= from blizzard, since he owns this stuff.
Should we be removing these files from the tree? i.e. is this still a good
example, or does it contain hacks that we avoid showing to future embeddors?
Please let it die.  I'm sick of getting email about problems with it. r/sr=blizzard
Attachment #53807 - Flags: superreview+
(Assignee)

Comment 10

16 years ago
gtkEmbed is now not-built, next step is to remove the code and references to
gtkEmbed.
(Assignee)

Comment 11

16 years ago
Created attachment 54019 [details] [diff] [review]
patch to remove last references to gtkEmbed
(Assignee)

Comment 12

16 years ago
latest patch, plus cvs removing embedding/tests/gtkEmbed should finish this off.
Looking for r/sr.

Comment 13

16 years ago
Comment on attachment 54019 [details] [diff] [review]
patch to remove last references to gtkEmbed

r=adamlock
Attachment #54019 - Flags: review+
Comment on attachment 54019 [details] [diff] [review]
patch to remove last references to gtkEmbed

sr=blizzard
Attachment #54019 - Flags: superreview+
(Assignee)

Comment 15

16 years ago
fixed, gtkEmbed is history now.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 16

16 years ago
Verified in 10/19 mozilla nightly build. References to gtkEmbed were removed in
makefiles:
* removed from makefile.in
* removed from allmakefiles.sh
* removed from basebrowser-unix. TestGtkEmbed was added.
* moz/embedding/tests/gtkEmbed removed from mk_sdk_hdr_lst.pl.
"$moz/embedding/browser/gtk/tests" was added.
Also, gtkEmbed is not on the tree. 
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.