Session Restore wastefully makes a database query per tab to fetch Favicons.

RESOLVED FIXED in Firefox 26

Status

()

Firefox for Android
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ckitching, Assigned: lucasr)

Tracking

Trunk
Firefox 26
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-fig])

(Reporter)

Description

4 years ago
Here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/widget/LastTabsSection.java#71

We're making a database query per tab to fetch favicons when doing session restore. This is wasteful. Instead we could batch-process the onTabRead events, do a single query, and greatly reduce overheads.
(Reporter)

Updated

4 years ago
Summary: Session Restore wastefully makes a databse query per tab to fetch Favicons. → Session Restore wastefully makes a database query per tab to fetch Favicons.

Comment 1

4 years ago
This file has been removed on fig, but it looks like the code still exists in LastTabsPage.

Is this a big pain point in practice? I feel like there aren't usually many tabs from last time. Also, now that the UI is different on fig, we should only be doing this when the user actually navigates to the LastTabsPage, so at least it won't affect startup.
(Assignee)

Comment 2

4 years ago
We could probably use getFaviconsForUrls() but I'd prefer something like bug 905685.
(Assignee)

Updated

4 years ago
Whiteboard: [mentor=lucasr][lang=java]
(Assignee)

Comment 3

4 years ago
FYI: my patch for bug 892500 will fix this.
Assignee: nobody → lucasr.at.mozilla
Whiteboard: [mentor=lucasr][lang=java]
(Assignee)

Comment 4

4 years ago
Pushed: http://hg.mozilla.org/projects/fig/rev/061fed4327f8
Blocks: 862793
Whiteboard: [fixed-fig]
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/061fed4327f8
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.