905300 - Remove dead code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

Yesterday I used gcov to generate code coverage data for the shell. This patch removes various functions that are unused.

It also removes some ScriptAnalysis bits and the analysis purge stuff. TypeCompartment::maybePurgeAnalysis had an early return so it was a no-op and with the TI rewrites (bug 804676 and others) we no longer need it.

 29 files changed, 20 insertions(+), 596 deletions(-)

Comment 1

[Jan de Mooij [:jandem]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/8687c8000152

(Try: https://tbpl.mozilla.org/?tree=Try&rev=81f685ee31cc)

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Follow-up fix

The patch removed an item from the enum in Workers.h but I forgot to update the other index values.

(Any reasons we don't use the enum names instead of their values, to make this less error-prone?)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8687c8000152

Comment 4

[Jan de Mooij [:jandem]]

Ben, review ping..

Comment 5

[Jan de Mooij [:jandem]]

Comment on attachment 790754 [details] [diff] [review]
Follow-up fix

No reply in > 10 days, let's try somebody else.

Comment 6

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 790754 [details] [diff] [review]
Follow-up fix

Review of attachment 790754 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, somehow I didn't see this until today. Looks fine, thanks.

Comment 7

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to Jan de Mooij [:jandem] from comment #2)
> (Any reasons we don't use the enum names instead of their values, to make
> this less error-prone?)

This sounds like a great idea, can we do a followup for that?

Comment 8

[Jan de Mooij [:jandem]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4d9ad776aa

(In reply to ben turner [:bent] (needinfo? encouraged) from comment #7)
> This sounds like a great idea, can we do a followup for that?

OK, I will file a DOM bug for that.

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1e4d9ad776aa