Closed
Bug 905314
Opened 11 years ago
Closed 11 years ago
Long tapping on a bookmark in the bookmarks tab no longer brings up the Bookmarks dialog
Categories
(Firefox OS Graveyard :: Gaia::Browser, defect)
Tracking
(b2g18 unaffected)
RESOLVED
DUPLICATE
of bug 906055
Tracking | Status | |
---|---|---|
b2g18 | --- | unaffected |
People
(Reporter: nhirata, Unassigned)
References
Details
(Whiteboard: regression, sprintready)
Attachments
(1 file)
"gecko" revision="3c61cc01a3b1" "gecko" revision="b33cd2bd329d8e051424e7a059e7443492f5ba01" "gaia" revision="9e0f6e30e5e28f88b4bbb4acb5e1fc99cdf7b7e7" Build ID: 2013-08-14-04-02-03 MC/master build Unagi 1. launch browser 2. go to www.google.com 3. bookmark the website 4. tap in the url 5. tap on bookmarks tab 6. long tap on the www.google.com bookmark Expected: Bookmarks menu dialog w/ unbookmark should appear Actual: nothing changes, releasing will go to the website. Note: 1. works in 1.1; fails in 1.2; it's a regression.
Reporter | ||
Updated•11 years ago
|
Summary: Long tapping on a bookmark in the bookmarks tab no longer brings up the → Long tapping on a bookmark in the bookmarks tab no longer brings up the Bookmarks dialog
Comment 1•11 years ago
|
||
It's probably a regression of bug 840210. This patch is to do ... 1. add bindBookmarkTabContextMenu method 2. execute bindBookmarkTabContextMenu if link of bookmark list is in cache 3. add needRefresh flag to force showBookmarksTab update bookmark list
Attachment #790671 -
Flags: review?(bfrancis)
Comment 2•11 years ago
|
||
Comment on attachment 790671 [details] PR to master Thanks for the bugfix but I looked for the regression range and found that it's actually a regression from bug 826497 and has been broken since June. I'm going to r- this patch because I think we need to find the underlying cause rather than just patch over it, I suspect that the patch from June caused other regressions too. I may re-factor this code in bug 833149 and these bugs may get fixed at the same time.
Attachment #790671 -
Flags: review?(bfrancis) → review-
Updated•11 years ago
|
Whiteboard: regression → regression, sprintready
Comment 3•11 years ago
|
||
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/55558564
Reporter | ||
Comment 5•11 years ago
|
||
Ben, without this, bug 804318 would be true, there's no way to remove a redirected web page. Since this is a regression, I am guessing that we should just wait for this to get fixed rather than write a new bug in regards to the bookmarks that are redirected. does that seem right to you?
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(nobody)
Reporter | ||
Updated•11 years ago
|
Flags: needinfo?(nobody) → needinfo?(bfrancis)
Comment 7•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/e986740cba9d61a7320994439085d22faf07eb8f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•