90538 - [mfcEmbed]Downloading files crashes mfcembed.exe

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[bmartin]

Latest mfcembed dated 07-11-01

O/S: Win2000
System: HP Vectra VL PIII-500MHz 128MB RAM

Steps:
1. Download and extract latest embed-win32.zip
2. Launch mfcEmbed.exe
3. Go to http://www.apple.com/quicktime/download/ and try to download QuickTime

Results:

"Program Error - mfcembed.exe has generated errors and will be closed by 
windows.  You will need to restart the program. An error log is being created."

I will attach the error log.

Comment 1

[bmartin]

Attachment: error log

Comment 2

[Chak Nanga]

Yet another packaging issue...

Works fine from the $DIST/bin dir. However, fails to show the external helper
app dialog when run from the Embed packaging dir.

Comment 3

[Chak Nanga]

Instead of packaging the XUL files we decided to show embeddors how to override 
the helper app handling UI.

Comment 4

[Chak Nanga]

Attachment: Preliminary patch - more work remaining [Mainly using as a backup]

Comment 5

[Chak Nanga]

Attachment: Patch which is ready for r=

Comment 6

[Chak Nanga]

Hi Dan : Can you r=when you get a chance?

Comment 7

[Judson Valeski]

Rather than building up the factory by hand, you should use the
NS_GENERIC_FACTORY_CONSTRUCTOR (here's an example
http://lxr.mozilla.org/seamonkey/source/netwerk/build/nsNetModule.cpp#68) macro.
That will clean out a lot of boilerplate code. It will also allow for this
component to be used in a static build configuration which requires modules to
register their factories w/ the macros.

nit. In CChooseActionDlg::OnInitDialog()... you can collapse the two "if
(mimeInfo)" stmts into one. Just drop the InitW/PerferredAction into the
previous "if (mimeInfo)".

after the factory change. r=valeski.

Comment 8

[Chak Nanga]

Attachment: Patch to MfcEmbed.cpp which overrides the helper app dlgs...

Comment 9

[Chak Nanga]

Hi Jud : Regarding your comments...

1. Took care of the two "if(mimeinfo)" checks by collapsing into one

2. I'm not able to use the NS_GENERIC_FACTORY_CONSTRUCTOR since i need to pass
in an |nsIFactory*| to RegisterFactory()[please see the latest patch].
Since using the NS_GENERIC_FACTORY_CONSTRUCTOR macro depends on the
GenericFactory  i need to be able to specify the GenericFactory in the call to
RegisterFactory.
   - I'm not sure how to get an interface pointer to the GenericFactory

Guess that's why Danm's using the non-generic factory approach to override the
PromptService as well.

Thanks

Comment 10

[Judson Valeski]

hmmm. sounds like a deficiency, but what you're saying makes sense. r=valeski.

Comment 11

[Chak Nanga]

Hi Chris : Can i get an sr= when you get a chance...Thanks

Comment 12

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 13

[Chak Nanga]

Fix has been checked in....

Comment 14

[Chak Nanga]

*** Bug 57884 has been marked as a duplicate of this bug. ***

Comment 15

[Michael Dunn]

Clean up verification of dated code change bus