905516 - strict warning in method/core

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I see this when running tests:

JavaScript strict warning: resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/d4/2p9g41l50tq6mscn2hxqsfmc0000gn/T/tmp9PCAY4.mozrunner/extensions/[e-mail]!/bootstrap.js -> resource://extensions.modules.0e92bb8d-412c-40c8-a29f-f68ee2a7001f-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.0e92bb8d-412c-40c8-a29f-f68ee2a7001f-at-jetpack.commonjs.path/method/core.js, line 102: reference to undefined property value[("!" + name)]
JavaScript strict warning: resource://gre/modules/XPIProvider.jsm -> jar:file:///var/folders/d4/2p9g41l50tq6mscn2hxqsfmc0000gn/T/tmp9PCAY4.mozrunner/extensions/[e-mail]!/bootstrap.js -> resource://extensions.modules.0e92bb8d-412c-40c8-a29f-f68ee2a7001f-at-jetpack.commonjs.path/toolkit/loader.js -> resource://extensions.modules.0e92bb8d-412c-40c8-a29f-f68ee2a7001f-at-jetpack.commonjs.path/method/core.js, line 102: reference to undefined property value[("!" + name)]

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Any idea what is wrong here?

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Yes, we do have a list of regexps in test runner to filter out stupid strict warnings like "reference to undefined property", I guess this one managed to be different enough so that test runner was not able to match and filter it out.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1204

Pointer to Github pull-request

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Irakli Gozilalishvili [:irakli] [:gozala] [@gozala] from comment #2)
> Yes, we do have a list of regexps in test runner to filter out stupid strict
> warnings like "reference to undefined property", I guess this one managed to
> be different enough so that test runner was not able to match and filter it
> out.

Adding this warning to that list didn't change anything fwiw.

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 792347 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1204

I thin we should just fix our filter to ignore reference to undefined properties. I was going to submit a pull request, but unfortunately github seems to commit changes when user has commit access to repo instead of submitting pull request :( So I basically end up commit this change:
https://github.com/mozilla/addon-sdk/commit/8327a731eb49e3b3f746a238dff34267a5aaa4b8

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1206

Pointer to Github pull-request

Comment 8

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 792393 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1206

See more comments in pull, but your comment in IRC made me realize that foo[bar[x]] may not be explicit enough so I'm proposing foo[bar[x] || undefined] to make it clear that author acknowledges what's going on. This seems to mitigate the problem.
I have submitted Bug 906866 to fix general warnings issue.

Comment 9

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/da85daa157d323d2dd597a670a3695b01b79fa10
Merge pull request #1206 from Gozala/bug/strict-wanings@905516

Bug 905516 - This mitigates problem by making intention explicit. r=@erikvold

Comment 10

[Jordan Santell [:jsantell] [@jsantell]]

Fixed