905537 - Add support for iPod Touch in useragent strings for platform detection

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Matthew N. [:MattN]]

+++ This bug was initially created as a clone of Bug #834290 +++

Bug 834290 missed iPod Touch devices which are functionally pretty close to iPhones except lacking cellular functionality. The token is "iPod" instead of iPhone or iPad.

Comment 1

[David Weir (satdav)]

Will add this ASAP for you

Comment 2

[David Lawrence [:dkl]]

Attachment: 905537_1.patch

Comment 3

[Frédéric Buclin]

Comment on attachment 790788 [details] [diff] [review]
905537_1.patch

From what I could see on the web, the UA string is of the form:

Mozila/5.0 (iPod; U; CPU like Mac OS X; en) AppleWebKit/420.1 (KHTML, like Geckto) Version/3.0 Mobile/3A101a Safari/419.3

So it won't match any of the OS 7, OS 6, ...., OS 3 regexps used to detect the OS. Only the last regexp will match. So only this last one should include iPod. The regexp for ARM is fine, though.

Comment 4

[David Lawrence [:dkl]]

Attachment: 905537_2.patch

Comment 5

[Frédéric Buclin]

Comment on attachment 790859 [details] [diff] [review]
905537_2.patch

r=LpSolit

Comment 6

[Matthew N. [:MattN]]

The first patch was better. Examples from [1] :
Mozilla/5.0 (iPod; U; CPU iPhone OS 4_3_3 like Mac OS X; ja-jp) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8J2 Safari/6533.18.5
Mozilla/5.0 (iPod; U; CPU iPhone OS 4_3_1 like Mac OS X; zh-cn) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8G4 Safari/6533.18.5
Mozilla/5.0 (iPod; U; CPU iPhone OS 4_2_1 like Mac OS X; he-il) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8C148 Safari/6533.18.5

The iOS version is now in the UA of the iPod Touch. I think iOS 3 are earlier may have been different.

[1] http://www.useragentstring.com/pages/Safari/

Comment 7

[Frédéric Buclin]

(In reply to Matthew N. [:MattN] from comment #6)
> The first patch was better.

The first patch wasn't better. The UA strings you pasted all contain iPhone already. They are already caught by the existing code.

Comment 8

[Matthew N. [:MattN]]

Ah, sorry. I missed that because I also saw the ones like comment 3 which don't have both models.

Comment 9

[David Lawrence [:dkl]]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified Bugzilla/UserAgent.pm
Committed revision 8704.

Comment 10

[Frédéric Buclin]

dkl: the checkin on the 4.4 branch is missing.

Comment 11

[David Lawrence [:dkl]]

Missed that.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4
modified Bugzilla/UserAgent.pm
Committed revision 8594. 

dkl