905614 - [Unit tests] Failed: ClockView updateAnalogClock with type error.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[[e-mail], [e-mail]]

1) [clock] ClockView updateAnalogClock "after each" hook:
    TypeError: attr is undefined
     at (anonymous) (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:125)
     at (anonymous) (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:124)
     at (anonymous) (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:127)
     at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
     at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
     at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
     at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
     at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)

Comment 1

[[e-mail], [e-mail]]

Hi Rick,
Could you please take a look the unit test failed? Thanks.

Comment 2

[Rick Waldron [:rwaldron]]

(In reply to Ian Liu [:ianliu] from comment #0)
> 1) [clock] ClockView updateAnalogClock "after each" hook:
>     TypeError: attr is undefined
>      at (anonymous)
> (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:125)
>      at (anonymous)
> (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:124)
>      at (anonymous)
> (http://clock.gaiamobile.org:8080/test/unit/clock_view_test.js:127)
>      at wrapper
> (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
>      at run
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
>      at next
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973)
>      at (anonymous)
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
>      at (anonymous)
> (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)


Strange... this doesn't happen when I run the tests. I wouldn't have made a PR with failing tests. 

I've written a patch that wraps the use of `attr.nodeName` in an if statement, so that will prevent the error. Unfortunately, without more information, this is all I can do.

Comment 3

[Rick Waldron [:rwaldron]]

See attached output for both terminal run and browser run

Comment 4

[Rick Waldron [:rwaldron]]

Attachment: 905614.txt

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: 905614.png

Comment 6

[Rick Waldron [:rwaldron]]

Attachment: 905614-clockview.png

Comment 7

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11552

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 790843 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11552

Fast-tracking this to fix a travis error.

Comment 9

[Kevin Grandon :kgrandon]

Follow-up landed in master: https://github.com/mozilla-b2g/gaia/commit/bfa7e855482b68c1414eaef1adaa7233ad5d019f

Comment 10

[[e-mail], [e-mail]]

(In reply to Rick Waldron from comment #2)
> Strange... this doesn't happen when I run the tests. I wouldn't have made a
> PR with failing tests. 
> 
> I've written a patch that wraps the use of `attr.nodeName` in an if
> statement, so that will prevent the error. Unfortunately, without more
> information, this is all I can do.
Rick,

Yes, I have checked the Travis log after you pushed the latest patch. There is no error log about Clock unit test. But the report was not completely since server be terminated by no respond 10 mins. (https://travis-ci.org/mozilla-b2g/gaia/builds/10215978) I have to notify you next time.


Kevin,

Thanks for your reviewing effort quickly.