905629 - Flag content as innapropriate

Status: RESOLVED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Brett Gaylor [:brett]]

In make details page, add ability for users to "flag" content as inappropriate.  Flagged content should be searchable in make editor.

Comment 1

[Chris DeCairos (:cade)]

I've asked Cassie via IRC to throw together a UI comp of this that I can use when implementing.

Comment 2

[Kat Braybrooke [:codekat]]

yep - this is big for content partners at moment. i also have suggested that we create editorial styleguide/guidelines that we can point users to if they ask why their make has been taken down. a site on webmaker somewhere that explains: a) what kinds of makes we feature, b) what kinds of makes are automatically flagged, c) what kinds of makes will be taken down. this will cover our backs :)

happy to start draft of this if helpful, have been meaning to do so for editorial stuff anyway. cassie, what works best re UI for such a guide?

Comment 3

[Cassie McDaniel [:cassiemc]]

Kat, I'd file that as a new bug. You can work with the front-end folks (Gavin, Kate, Dale) to implement a page like that based on the design style guide / standard template we have - most important will be the content.

As discussed in IRC, let's leave this bug as a simple first implementation of the "report content" functionality, that makes flagged content easier to find via the Make API. These makes will have to be reviewed manually initially, until we can implement some automated tests that check for curse words, porn, etc (and in other languages, as well).

Comment 4

[Cassie McDaniel [:cassiemc]]

Attachment: Report-content.pdf

Added a report link up at the top, next to the byline / time passed. This necessitates the "Share" button being moved, so I will make this bug dependent on that. The "report" text should be the blue link colour, same size as the time/hours/date.

The second page shows what happens when it is clicked. Clicking on the link again will undo the "report" action.

These should have the same hover states as other links in the make details panel. (underline and slightly lighter).

Comment 5

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/makeapi-client/pull/13

MakeAPI client commit

Comment 6

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/MakeAPI/pull/141

MakeAPI commit

Comment 7

[Chris DeCairos (:cade)]

Attachment: https://github.com/mozilla/webmaker.org/pull/354

Webmaker.org commit

Comment 8

[Matthew Schranz [:mjschranz]]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

Nits and questions.

Comment 9

[Matthew Schranz [:mjschranz]]

Comment on attachment 800916 [details] [review]
https://github.com/mozilla/makeapi-client/pull/13

Don't mind me. I'm just crazy.

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/makeapi-client

https://github.com/mozilla/makeapi-client/commit/3d108a7c2ee9001e19d3863a5e5680f9eb7ed72d
Bug 905629 - Add report and cancelReport API method support

Comment 11

[Chris DeCairos (:cade)]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

updated!

Comment 12

[Matthew Schranz [:mjschranz]]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

Some comments.

Comment 13

[Matthew Schranz [:mjschranz]]

Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

See comments.

Functionally this works well.

Comment 14

[inactivate account for kate]

Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

Some comments in the PR

Comment 15

[Chris DeCairos (:cade)]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

updated.

Comment 16

[Chris DeCairos (:cade)]

Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

updated!

Comment 17

[Jacob [:Jacob]]

I'm going to add the comment I had when this was first demoed, which is that I think we need a double confirmation so people don't toggle it by mistake and we have to weed through a bunch of them.

It makes sense to me to have a second warning box that pops up and explains "you are about to flag something as inappropriate, please see our guidelines [link] on how this process works" that they then have to confirm.

Humph said he wants to test this first, so we'll see what happens. This is how Facebook and other services do it.

Comment 18

[Chris DeCairos (:cade)]

(In reply to Jacob [:Jacob] from comment #17)
> I think we need a double confirmation so people don't toggle it by mistake
> and we have to weed through a bunch of them.

Yeah, I think this is the best way to go. I'll implement a two step reporting process. 

This bug cannot land until we put up Editorial Guidelines for Webmaker ( Bug 909802 )

Comment 19

[Chris DeCairos (:cade)]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

I've re-based this onto master and made some changes to get it working again.

Lets do another review, then actually ship it.

Comment 20

[Matthew Schranz [:mjschranz]]

Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

Some small stuff on where you put the strings.

I'm wondering though, can we prevent the share button from shifting left/right when the report toggle is clicked?

Comment 21

[Matthew Schranz [:mjschranz]]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

R+ with lint failures fixed.

Comment 22

[Chris DeCairos (:cade)]

(In reply to Matthew Schranz [:mjschranz] from comment #20)
> I'm wondering though, can we prevent the share button from shifting
> left/right when the report toggle is clicked?

I don't think it's important, since it's out of place and supposed to be moved by bug 909775

Comment 23

[Chris DeCairos (:cade)]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

setting back to review. I added a "sort by most reported" option on the admin panel, and fixed script sorting for likes and reports.

Comment 24

[Matthew Schranz [:mjschranz]]

Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

I brought up one minor thing in the comments, but R+ anyway. Not a big deal.

Comment 25

[[github robot]]

Commit pushed to master at https://github.com/mozilla/MakeAPI

https://github.com/mozilla/MakeAPI/commit/e2d82898cdf0790d00aa0da992719549ce5acff8
Bug 905629 - Implement reporting makes

Comment 26

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/deccff53701ee434378ba82e62e8f22ec7110ed9
Bug 905629 - Implement reporting makes

Comment 27

[JP Schneider :jp]

Ran this on ES prod/staging for makeapi:

root@i-3049d155:/usr/share/elasticsearch# bin/plugin -install elasticsearch/elasticsearch-lang-javascript/1.4.0