Flag content as innapropriate

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: brett, Assigned: cade)

Tracking

Details

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
In make details page, add ability for users to "flag" content as inappropriate.  Flagged content should be searchable in make editor.
(Assignee)

Comment 1

5 years ago
I've asked Cassie via IRC to throw together a UI comp of this that I can use when implementing.
Status: NEW → ASSIGNED
Flags: needinfo?(cassie)
yep - this is big for content partners at moment. i also have suggested that we create editorial styleguide/guidelines that we can point users to if they ask why their make has been taken down. a site on webmaker somewhere that explains: a) what kinds of makes we feature, b) what kinds of makes are automatically flagged, c) what kinds of makes will be taken down. this will cover our backs :)

happy to start draft of this if helpful, have been meaning to do so for editorial stuff anyway. cassie, what works best re UI for such a guide?
Kat, I'd file that as a new bug. You can work with the front-end folks (Gavin, Kate, Dale) to implement a page like that based on the design style guide / standard template we have - most important will be the content.

As discussed in IRC, let's leave this bug as a simple first implementation of the "report content" functionality, that makes flagged content easier to find via the Make API. These makes will have to be reviewed manually initially, until we can implement some automated tests that check for curse words, porn, etc (and in other languages, as well).
Depends on: 909775
Flags: needinfo?(cassie)
Created attachment 796075 [details]
Report-content.pdf

Added a report link up at the top, next to the byline / time passed. This necessitates the "Share" button being moved, so I will make this bug dependent on that. The "report" text should be the blue link colour, same size as the time/hours/date.

The second page shows what happens when it is clicked. Clicking on the link again will undo the "report" action.

These should have the same hover states as other links in the make details panel. (underline and slightly lighter).
Depends on: 909802
(Assignee)

Comment 5

5 years ago
Created attachment 800916 [details] [review]
https://github.com/mozilla/makeapi-client/pull/13

MakeAPI client commit
Attachment #800916 - Flags: review?(schranz.m)
Attachment #800916 - Flags: review?(kate)
(Assignee)

Comment 6

5 years ago
Created attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

MakeAPI commit
Attachment #800917 - Flags: review?(schranz.m)
Attachment #800917 - Flags: review?(kate)
(Assignee)

Comment 7

5 years ago
Created attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

Webmaker.org commit
Attachment #800920 - Flags: review?(schranz.m)
Attachment #800920 - Flags: review?(kate)
Attachment #800916 - Flags: review?(schranz.m) → review+
Attachment #800916 - Flags: review?(kate) → review+
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

Nits and questions.
Attachment #800917 - Flags: review?(schranz.m) → review-
Comment on attachment 800916 [details] [review]
https://github.com/mozilla/makeapi-client/pull/13

Don't mind me. I'm just crazy.
Attachment #800916 - Flags: review+ → review?(kate)
(Assignee)

Comment 11

5 years ago
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

updated!
Attachment #800917 - Flags: review- → review?(schranz.m)
(Assignee)

Updated

5 years ago
Attachment #800916 - Flags: review?(kate)
Attachment #800917 - Flags: review?(kate) → review+
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

Some comments.
Attachment #800917 - Flags: review?(schranz.m) → review-
Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

See comments.

Functionally this works well.
Attachment #800920 - Flags: review?(schranz.m) → review-
Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

Some comments in the PR
Attachment #800920 - Flags: review?(kate) → review-
(Assignee)

Comment 15

5 years ago
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

updated.
Attachment #800917 - Flags: review- → review?(schranz.m)
(Assignee)

Comment 16

5 years ago
Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

updated!
Attachment #800920 - Flags: review?(schranz.m)
Attachment #800920 - Flags: review?(kate)
Attachment #800920 - Flags: review-
Attachment #800917 - Flags: review?(schranz.m) → review+
Attachment #800920 - Flags: review?(schranz.m) → review+
Attachment #800920 - Flags: review?(kate) → review+

Comment 17

5 years ago
I'm going to add the comment I had when this was first demoed, which is that I think we need a double confirmation so people don't toggle it by mistake and we have to weed through a bunch of them.

It makes sense to me to have a second warning box that pops up and explains "you are about to flag something as inappropriate, please see our guidelines [link] on how this process works" that they then have to confirm.

Humph said he wants to test this first, so we'll see what happens. This is how Facebook and other services do it.
(Assignee)

Comment 18

5 years ago
(In reply to Jacob [:Jacob] from comment #17)
> I think we need a double confirmation so people don't toggle it by mistake
> and we have to weed through a bunch of them.

Yeah, I think this is the best way to go. I'll implement a two step reporting process. 

This bug cannot land until we put up Editorial Guidelines for Webmaker ( Bug 909802 )
(Assignee)

Updated

5 years ago
No longer depends on: 909775
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
(Assignee)

Comment 19

5 years ago
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

I've re-based this onto master and made some changes to get it working again.

Lets do another review, then actually ship it.
Attachment #800917 - Flags: review+ → review?(schranz.m)
(Assignee)

Updated

5 years ago
Attachment #800920 - Flags: review+ → review?(schranz.m)
Comment on attachment 800920 [details]
https://github.com/mozilla/webmaker.org/pull/354

Some small stuff on where you put the strings.

I'm wondering though, can we prevent the share button from shifting left/right when the report toggle is clicked?
Attachment #800920 - Flags: review?(schranz.m) → review-
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

R+ with lint failures fixed.
Attachment #800917 - Flags: review?(schranz.m) → review+
(Assignee)

Updated

5 years ago
Attachment #800920 - Attachment description: https://github.com/mozilla/webmaker.org/pull/354/files → https://github.com/mozilla/webmaker.org/pull/354
Attachment #800920 - Attachment mime type: text/plain → text/x-github-pull-request
(Assignee)

Comment 22

5 years ago
(In reply to Matthew Schranz [:mjschranz] from comment #20)
> I'm wondering though, can we prevent the share button from shifting
> left/right when the report toggle is clicked?

I don't think it's important, since it's out of place and supposed to be moved by bug 909775
(Assignee)

Updated

5 years ago
Attachment #800920 - Flags: review- → review?(schranz.m)
Attachment #800920 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 23

5 years ago
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

setting back to review. I added a "sort by most reported" option on the admin panel, and fixed script sorting for likes and reports.
Attachment #800917 - Flags: review+ → review?(schranz.m)
Comment on attachment 800917 [details] [review]
https://github.com/mozilla/MakeAPI/pull/141

I brought up one minor thing in the comments, but R+ anyway. Not a big deal.
Attachment #800917 - Flags: review?(schranz.m) → review+

Comment 27

5 years ago
Ran this on ES prod/staging for makeapi:

root@i-3049d155:/usr/share/elasticsearch# bin/plugin -install elasticsearch/elasticsearch-lang-javascript/1.4.0
(Assignee)

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.