905634 - When text events are no longer custom, they can cover other interactive events

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[Scott [:thecount] Downe]

STR:

1. open this: https://scott.makes.org/popcorn/1bni
2. seek between 8 and 11.
3. attempt to select the text at that bottom, that says it can be selected.

Expected: selected text.
Actual: it attempts to select any number of fixed text divs.

Comment 1

[Scott [:thecount] Downe]

I won't be able to get to this until Tuesday, so Matt if you get to it before that please do. It's an issue people are hitting.

At the very least should be in popbetter.

Comment 2

[Matthew Schranz [:mjschranz]]

Bah, not actually effective str....

Comment 3

[Matthew Schranz [:mjschranz]]

Causing commit: https://github.com/mozilla/popcorn.webmaker.org/commit/16393f1f86a351075492a60f9730dbad54ee696f

STR:

1) Put an image event on layer 0, say start: 0 and end: 5.
2) Put a text event on layer 1, say start: 2 and end: 7.
3) Change that text events "Text Position" to either Middle, Top or Bottom (one of our fixed positions).

Because of how fixed position events work, and this selectable patch flicking almost anywhere causes us to be able to trigger this bug.

Comment 4

[Matthew Schranz [:mjschranz]]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/178

Fixes most of the problem, still one small thing to solve where magically the text events stop responding to start/end currentTime changes.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 793570 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/178

The text events are stop responding to start/end as soon as content editable is triggered, which happens on a click. If changes happen it is fine, though. So an update fixes it. A select without an update does not.

Also, as soon as content editable is triggered, it no longer highlights it on future selects. Again, fixed if an edit happens.

Your patch does solve the largest issue, but I feel like it was a quick fix, and avoids the problem as to the fact our fixed position solution is a problem. I would rather fix the fixed position hacks, instead of working around it, but I don't know of a solution yet, and your fix is small enough.

File a new ticket on the above if you want to land this now.

Comment 6

[Matthew Schranz [:mjschranz]]

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=909770

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/d6489678b3579d62d2e544eac0760ca8abe6c103
Fix Bug 905634 - Prevent fixed position text events have their selectable state always triggerable even when not currently visible

Comment 8

[Matthew Schranz [:mjschranz]]

On production.