905678 - Use FrameAnimator class in RasterImage

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Milan Sreckovic [:milan] (needinfo for best results)]

+++ This bug was initially created as a clone of Bug #899861 +++

The fix in bug 899861 was a (slightly minimized) back out of a part 7 patch from bug 717872.  This bug is to track the real fix, that uses FrameAnimator, but does not have the problem reported in bug 899861.

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

Once bug 905793 is fixed, we may just want to back out the fix to bug 899861 and go back to the code as originally written.

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Backout the fix for bug 899861, which was itself a backout of a part of 717872.

This gets us back to the part 7 of bug 717872. It needs bug 905793 landed to not regress bug 899861.

Comment 3

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 792952 [details] [diff] [review]
Backout the fix for bug 899861, which was itself a backout of a part of 717872.

Review of attachment 792952 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Please update the commit message to say "r=seth" rather than "r=bgirard".

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Backout the fix for bug 899861, which was itself a backout of a part of 717872.

This gets us back to the part 7 of bug 717872. It needs bug 905793 landed to not regress bug 899861.  Carry r+ from seth, just had the r= part in the comment wrong.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c4fb173290bb

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c4fb173290bb