Closed
Bug 905678
Opened 12 years ago
Closed 12 years ago
Use FrameAnimator class in RasterImage
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
RESOLVED
FIXED
mozilla26
| Tracking | Status | |
|---|---|---|
| firefox24 | --- | unaffected |
| firefox25 | - | affected |
People
(Reporter: milan, Assigned: milan)
References
Details
Attachments
(1 file, 1 obsolete file)
|
23.55 KB,
patch
|
milan
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #899861 +++
The fix in bug 899861 was a (slightly minimized) back out of a part 7 patch from bug 717872. This bug is to track the real fix, that uses FrameAnimator, but does not have the problem reported in bug 899861.
|
Assignee | |
Updated•12 years ago
|
Keywords: regression
OS: Windows 7 → All
|
|
Assignee | |
Comment 1•12 years ago
|
||
Once bug 905793 is fixed, we may just want to back out the fix to bug 899861 and go back to the code as originally written.
|
|
Assignee | |
Comment 2•12 years ago
|
||
This gets us back to the part 7 of bug 717872. It needs bug 905793 landed to not regress bug 899861.
Attachment #792952 -
Flags: review?(seth)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 792952 [details] [diff] [review]
Backout the fix for bug 899861, which was itself a backout of a part of 717872.
Review of attachment 792952 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good. Please update the commit message to say "r=seth" rather than "r=bgirard".
Attachment #792952 -
Flags: review?(seth) → review+
|
|
Assignee | |
Comment 6•12 years ago
|
||
This gets us back to the part 7 of bug 717872. It needs bug 905793 landed to not regress bug 899861. Carry r+ from seth, just had the r= part in the comment wrong.
Attachment #792952 -
Attachment is obsolete: true
Attachment #793067 -
Flags: review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
||
Comment 7•12 years ago
|
||
Keywords: checkin-needed
|
||
Comment 8•12 years ago
|
||
Assignee: nobody → milan
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•