905680 - Windows7 Aero is completely broken

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/aada0f74faf9
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130815035918

In latest m-c tinderbox build,
Windows7 Aero is completely broken:
No Aero Glas in Windows Border/Title bar/Toolbar.
Small window control button(minimize/restore/maximize/close)

Regression window(m-i)
Good:
http://hg.mozilla.org/integration/mozilla-inbound/rev/941ccccfeaa7
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130814210817
Bad:
http://hg.mozilla.org/integration/mozilla-inbound/rev/533ac6b8ee38
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130814212517
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=941ccccfeaa7&tochange=533ac6b8ee38

Comment 1

[Alice0775 White]

Attachment: screenshot

Comment 3

[Jim Jeffery not reading bug-mail 1/2/11]

Attachment: titlebar.jpg

Another screen shot showing ID 10 vs Nighly (hourly m-c) build

Comment 4

[Jim Jeffery not reading bug-mail 1/2/11]

I would like to also point out that the Windows control buttons appears to be too small as compared to Say IE 10 or Latest Chrome.

I believe I recall that when tabs-in-the-title-bar first landed there was a similar issue with the control-buttons being too small

Comment 5

[Avi Halachmi (:avih)]

Guys, this is caused by the refactoring of 900785 patch part 1, most probably due to incorrect of init order. See bug 900785 comment 41 onwards. The change is one line, and I hope it lands as soon as roc wakes up.

Comment 6

[Avi Halachmi (:avih)]

Attachment: fix Aero on win7/8 (regression from Bug 900785 part 2)

r=roc via IRC.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a8a4e293d39

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a8a4e293d39

Comment 11

[Avi Halachmi (:avih)]

If anyone is interested in testing the fix, this is the first mozilla-central build which includes id: http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1376641703/

The next nightly should be fixed as well.

Comment 12

[Ekanan Ketunuti]

Windows7 Aero works fine in Nightly 26.0a1 buildid 20130827030201