905684 - [Clock] Convert all inline HTML to templates stored in index.html

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect)

Description

[Rick Waldron [:rwaldron]]

There is currently markup strings inline within alarm_list.js that needs to be migrated to using a template system where the source HTML lives in index.html

I propose we use the same (reasonably well tested) system that we used in Messages. This should mean that we move Utils.Template to /shared/js/ and ideally rename it Template.

Requesting koi+ since this will be become a dependency of all templated markup that gets added as we implement new features for 1.2

Comment 1

[Rick Waldron [:rwaldron]]

More markup in banner.js


  this.bannerCountdown.innerHTML = '<p>' + innerHTML + '</p>';

Comment 2

[James Lal [:lightsofapollo]]

FYI- This was -'ed because you don't need permission to land this as it would block your "feature" work. If this lands on master before branching (which It sounds like it will given you assigned yourself) life is good and no action is needed.

Comment 3

[Rick Waldron [:rwaldron]]

(In reply to James Lal [:lightsofapollo] from comment #2)
> FYI- This was -'ed because you don't need permission to land this as it
> would block your "feature" work. If this lands on master before branching
> (which It sounds like it will given you assigned yourself) life is good and
> no action is needed.

I don't see that it was "-'ed"

Comment 4

[Dylan Oliver [:doliver]]

(In reply to Rick Waldron from comment #3)
> I don't see that it was "-'ed"

Oops, it was verbally blocking- in triage but we forgot to push the buttons. Doing so now.

Comment 5

[Marcus Cavanaugh [:mcav]]

Appears to be fixed in master through refactoring; no raw HTML strings are in the files mentioned any more.