905775 - Firefox is failing silently in recent travis builds during `make test-agent-test` step

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Comment 1

[Julien Wajsberg [:julienw]]

I have a patch that seems to fix things.

see https://github.com/mozilla-b2g/gaia/pull/11639

Basically I add DESKTOP=0 to the travis launch script, and I add the touch events for the DEBUG profiles.

I had 2 different travis runs with only the DESKTOP=0 changes and both went to the end, with touch-related failures.

New travis run with the touch change is https://travis-ci.org/mozilla-b2g/gaia/builds/10443463, let's see how it goes.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: patch v1

The travis run went to the end again, so that's good.

Let's land this if that feels good to you !

Comment 3

[Julien Wajsberg [:julienw]]

PR is at https://github.com/mozilla-b2g/gaia/pull/11639

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 793397 [details] [diff] [review]
patch v1

asking review from Yuren but if Gareth, James, Kevin or Alexandre wants to steal the review, please do

Comment 5

[Alexandre Poirot [:ochameau]]

Do we know what is the precise error that happen silently?
If tests are run on firefox, we should keep DESKTOP=1 mode,
as there is various prefs we want to be set on firefox:
  https://github.com/julienw/gaia/blob/d86643eb06025883cf9a83e1f4f40147f1cf3eb9/build/preferences.js#L58-L79
Otherwise, if they are run on b2g desktop, we should ensure disabling this mode and set DESKTOP=0. But then we wouldn't need to set the touch preference as it should already be set in b2g desktop.

Comment 6

[Julien Wajsberg [:julienw]]

investigating more with Alexandre.

Comment 7

[Julien Wajsberg [:julienw]]

On an idea from Alexandre, this is a PR with only the httpd extension, but keeping the DESKTOP=1 prefs:

https://github.com/mozilla-b2g/gaia/pull/11659

Let's see what travis says about this (https://travis-ci.org/mozilla-b2g/gaia/builds/10448076).

Also, if we finally remove DESKTOP for unit tests, I think we still need it for integration tests, otherwise gaia will not load successfully, so we'll need to generate to different profiles.

Finally, we might need to do bug 885544 to fix this correctly... but removing DESKTOP=1 would work for me temporarily.

Comment 8

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Julien, could you explain why does it work with with enable touch event and DESKTOP=0? for running unit test we shold use DEBUG=1 so DESKTOP also is 1.

Comment 9

[Julien Wajsberg [:julienw]]

I use "DEBUG=1 DESKTOP=0"... which was the setup we had before DESKTOP stuff existed, and it worked very well. I don't think we need most of the DESKTOP stuff for running unit tests. Probably we could add the various API though, even if good unit tests should always mock the API and not use them. (this is not true for integration tests of course).

However I'm currently trying to find what exactly in the DESKTOP stuff is breaking things.

Comment 10

[Julien Wajsberg [:julienw]]

> Also, if we finally remove DESKTOP for unit tests, I think we still need it for integration tests, otherwise gaia will not load successfully, so we'll need to generate to different profiles.

ok, that's already done, forget this comment.

Comment 11

[Kevin Grandon :kgrandon]

I've noticed that running the entire suite locally in firefox is also breaking. My bet would be that it's the same issue. If this fixes it I'd think we can land, but I do want to find the root cause so developers can run everything locally.

Comment 12

[Julien Wajsberg [:julienw]]

James, Kevin, we'd like your input here. Either we land this temporarily until we find the root cause (but there is a high probability we won't have time to do this), or we find the root cause now (but travis is broken until then).

Comment 13

[Julien Wajsberg [:julienw]]

Kevin> strangely it works for me locally with DEBUG=1 (and therefore DESKTOP=1).

Comment 14

[James Lal [:lightsofapollo]]

Anything that makes travis work ASAP works for me... There are lots of things I want for us to fix to make debugging this go from "insanely time consuming" -> "trivial" and would rather spend the time it would take to figure it out getting there instead.

Comment 15

[Anthony Ricaud (:rik)]

I saw this Firefox crash while running the whole test suite: https://crash-stats.mozilla.com/report/index/12ac33b0-e0e0-46bc-9802-f660b2130821

Comment 16

[Julien Wajsberg [:julienw]]

ok then just r+ and let's land this to have at least something in travis.

Comment 17

[Alexandre Poirot [:ochameau]]

Comment on attachment 793397 [details] [diff] [review]
patch v1

I'm fine with this patch as soon as we continue trying to find the underlying issue. Making progressive Travis stdout output to work sounds like a good think to fix in order to ease understanding what is being wrong with these prefs.

Comment 18

[Julien Wajsberg [:julienw]]

master: 13971a3d832bd44f3b9b97914111fa6ce76c5a42

thanks Alexandre !
The "progressive output" bug is bug 907621.