Closed Bug 905822 Opened 8 years ago Closed 8 years ago

Annotate manifests with run-sequentially

Categories

(MailNews Core :: Testing Infrastructure, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 26.0

People

(Reporter: mihneadb, Assigned: mihneadb)

Details

Attachments

(1 file)

Doing this so the new parxpc patch doesn't cause bustage.
Summary: Annotate manifests with run0-sequentially → Annotate manifests with run-sequentially
Assignee: nobody → mihneadb
Status: NEW → ASSIGNED
Attachment #790976 - Flags: review?(Pidgeot18)
Comment on attachment 790976 [details] [diff] [review]
Annotate manifests with run-sequentially

Review of attachment 790976 [details] [diff] [review]:
-----------------------------------------------------------------

Okay, so running tests in parallel right now requires using mach, which is broken as hell for comm-central, so this is not an imminently-needed bustage fix. Still, bug 660788 could land soonish, so it's good to have all of this in so we don't make our xpcshell test coverage go down the drain again.

Without this patch, I get 184 failures out of 287 for mailnews, including some epically complete bustage in at least news and IMAP, and sporadic failures in compose and gloda it looks like (hard to classify scrolling pages of failing tests).
Attachment #790976 - Flags: review?(Pidgeot18) → review+
(In reply to Joshua Cranmer [:jcranmer] from comment #2)
> Comment on attachment 790976 [details] [diff] [review]
> Annotate manifests with run-sequentially
> 
> Review of attachment 790976 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Okay, so running tests in parallel right now requires using mach, which is
> broken as hell for comm-central, so this is not an imminently-needed bustage
> fix. Still, bug 660788 could land soonish, so it's good to have all of this
> in so we don't make our xpcshell test coverage go down the drain again.
> 
> Without this patch, I get 184 failures out of 287 for mailnews, including
> some epically complete bustage in at least news and IMAP, and sporadic
> failures in compose and gloda it looks like (hard to classify scrolling
> pages of failing tests).

So what do you get *with* the patch? :)
Only the failures of bug 901959. :-)
Ah, sweet, so my patch fixes the problem.
https://hg.mozilla.org/comm-central/rev/e99c2bc2eda1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
You need to log in before you can comment on or make changes to this bug.