Closed Bug 905831 Opened 11 years ago Closed 11 years ago

[Browser] Searching for words in the URL bar is not giving a search results

Categories

(Firefox OS Graveyard :: Gaia::Browser, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Browser
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g koi+

People

(Reporter: nhirata, Unassigned)

References

Details

(Keywords: qablocker, Whiteboard: sprintready)

Attachments

(3 files)

init.json
37.70 KB, application/json
Details
logcat.txt
26.54 KB, text/plain
Details
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11721
358 bytes, text/html
benfrancis
: review+
Details 
## Environment :
"gecko" revision="a8daa428ccbc"
"gecko" revision="f7df54d21e1b4fed66083d80b701c3692e1cffd4"
"gaia" revision="58bb05efc83407428099a182244a1759ab84cd0b"
Build ID: 2013-08-15-04-02-04
MC/master build
Unagi

Prereq: no SIM card

STR:
1. launch browser
2. tap in the URL bar
3. type "Yomiuri"
4. tap the magnifying glass icon

Expected: A search from the default search engine with results of "yomiuri"
Actual: www.yomiuri.com in URL bar / Server not found error in content

Note:
1. also tried "test blah" return result was http://test blah
Hey Brad and Ben, I'm not getting the search engine results like I think I should be getting.  Am I doing something wrong?
blocking-b2g: --- → koi?
Flags: needinfo?(blassey.bugs)
Keywords: qablocker
Flags: needinfo?(bfrancis)
You probably need to do make reset-gaia instead of make install-gaia.

The new search engine customisation needs data provided in init.json which is generated at build time and will need to be included in OTA updates.

Sorry, should have warned you about that.
Flags: needinfo?(bfrancis)
I flashed the whole device with the image so it should have deleted any previous userdata.  As a test I also tried to use a special character and no search engine result was provided.
Oh.  I hit send too quick.  I guess the init.json wasn't checked into the build and that's what's causing the breakage in the releng build.  Got it.  So basically the releng build and the OTA needs to have the init.json.
So I tried just |make reset-gaia| and I found that the init.json was created in my compilation directory.  I then pulled the application.zip from /data/local/webapps/browser.gaiamobile.org off the device.  Once the folder was unziped, I did find the init.json in the js folder.

I don't think that the json is being read correctly?
Flags: needinfo?(bfrancis)
This is reproducible in our Automation suite:
https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/tests/browser/test_browser_search.py

on:
Gecko  http://hg.mozilla.org/mozilla-central/rev/a8daa428ccbc
Gaia  58bb05efc83407428099a182244a1759ab84cd0b
BuildID 20130815040204
Version 26.0a1
That's odd, I can't reproduce this.

Can you paste the contents of init.json ? It should contain data about search engines.

Can you see any error messages?
Flags: needinfo?(bfrancis)
Flags: needinfo?(blassey.bugs)
Attached file init.json — 
Attached is the init.json
Attached file logcat.txt — 
Logcat does show an error message:

08-16 14:00:45.244: E/GeckoConsole(109): Content JS LOG at app://browser.gaiamobile.org/gaia_build_defer_index.js:258 in browserDB_populate: Populating browser database.
08-16 14:00:45.764: E/GeckoConsole(109): [JavaScript Error: "not well-formed" {file: "app://browser.gaiamobile.org/js/init.json" line: 1 column: 1 source: "{"}]
08-16 14:00:46.675: I/Gecko(483): MobileConnection initialized
08-16 14:00:47.406: E/Profiler(737): BEGIN mozilla_sampler_init
08-16 14:00:47.406: E/Profiler(738): BEGIN mozilla_sampler_init
Marking koi+ in case this is a real bug, but Dale and I still can't reproduce so more information about how you're creating your builds might be helpful.
blocking-b2g: koi? → koi+
Whiteboard: sprintready
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/55436456
I am putting this really high in our backlog in case this is a real bug, although this really does need to be reproducible.
I am not sure about releng and how they create it; I have a github pull of Gaia and I am building on the Mac platform.

My thought is that there might be a control character hidden?  I am not sure.  I guess I can try editing and recompiling...
I think I have up to date gaia, performed reset-gaia, and that I'm reproducing this issue on my Inari.
Gecko and gaia master, uptodate of now, and after running: |make clean && make MOZILLA_OFFICIAL=1 PRODUCTION=1 NOFTU=1 REMOTE_DEBUGGER=1 reset-gaia|, entering « test » in the URL bar, taping the magnifying glass icon, I'm not redirected on a search engine. And it persists across reboots.
Assignee: nobody → lissyx+mozillians
Assignee: lissyx+mozillians → nobody
For reference, here is the logcat when the error is exposed. This is an Inari, connected to Mozilla Guest for WiFi and with a Orange F (20801) SIM card, locale set to English. Gaia is from august 22th

--------- beginning of /dev/log/main
I/Gonk    (  787): Setting nice for pid 825 to 1
I/Gonk    (  787): Changed nice for pid 825 from 18 to 1.
I/Gecko   (  787): ###################################### forms.js loaded
I/Gecko   (  787): ############################### browserElementPanning.js loaded
I/Gecko   (  787): ######################## BrowserElementChildPreload.js loaded
I/Gonk    (  787): Setting nice for pid 825 to 18
I/Gonk    (  787): Changed nice for pid 825 from 1 to 18.
E/GeckoConsole(  787): Content JS LOG at app://browser.gaiamobile.org/gaia_build_defer_index.js:273 in onUpgradeNeeded: Browser database upgrade needed, upgrading.
I/Gonk    (  787): Setting nice for pid 1060 to 1
I/Gonk    (  787): Changed nice for pid 1060 from 0 to 1.
I/Gonk    (  787): Setting nice for pid 1060 to 18
I/Gonk    (  787): Changed nice for pid 1060 from 1 to 18.
E/GeckoConsole(  787): Content JS LOG at app://browser.gaiamobile.org/gaia_build_defer_index.js:258 in browserDB_populate: Populating browser database.
E/GeckoConsole(  787): [JavaScript Error: "not well-formed" {file: "app://browser.gaiamobile.org/js/init.json" line: 1 column: 1 source: "{"}]
E/Profiler( 1060): BEGIN mozilla_sampler_init
E/Profiler( 1060): BPUnw: [1 total] thread_register_for_profiling(me=0x401334f8, stacktop=0xbeb25927)
E/Profiler( 1060): SPS:
E/Profiler( 1060): SPS: Unwind mode       = pseudo
E/Profiler( 1060): SPS: Sampling interval = 0 ms (zero means "platform default")
E/Profiler( 1060): SPS: Entry store size  = 0 (zero means "platform default")
E/Profiler( 1060): SPS: UnwindStackScan   = 0 (max dubious frames per unwind).
E/Profiler( 1060): SPS: Use env var MOZ_PROFILER_MODE=help for further information.
E/Profiler( 1060): SPS:
E/Profiler( 1060): Registering start signal
I/Gecko   ( 1060): ###################################### forms.js loaded
I/Gecko   ( 1060): ############################### browserElementPanning.js loaded
I/Gecko   ( 1060): ######################## BrowserElementChildPreload.js loaded
I/Gecko   ( 1060): ###################################### forms.js loaded
I/Gecko   ( 1060): ############################### browserElementPanning.js loaded
I/Gecko   ( 1060): ######################## BrowserElementChildPreload.js loaded
--------- beginning of /dev/log/system
I/Gonk    (  787): Setting nice for pid 1060 to 1
I/Gonk    (  787): Changed nice for pid 1060 from 18 to 1.
E/GeckoConsole(  787): Content JS LOG at app://browser.gaiamobile.org/gaia_build_defer_index.js:272 in getIconError: Error fetching icon
E/GeckoConsole( 1060): [JavaScript Warning: "Unknown property 'zoom'.  Declaration dropped." {file: "http://www.toto.co.jp/company/shared/css/print.css" line: 11 column: 5 source: "	zoom:1;"}]
E/GeckoConsole( 1060): [JavaScript Warning: "Unknown property 'zoom'.  Declaration dropped." {file: "http://www.toto.co.jp/company/shared/css/base.css" line: 11 column: 5 source: "	zoom:1;"}]
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole(  787): ThirdPartyCookieProbe: Uncaught error [Exception... "Component returned failure code: 0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) [nsIEffectiveTLDService.getBaseDomainFromHost]"  nsresult: "0x804b0050 (NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS)"  location: "JS frame :: resource://gre/modules/ThirdPartyCookieProbe.jsm :: normalizeHost :: line 181"  data: no]
E/GeckoConsole(  787): undefined
E/GeckoConsole( 1060): [JavaScript Warning: "Unknown property 'zoom'.  Declaration dropped." {file: "http://cache.dga.jp/s/toto/ac.css" line: 44 column: 8 source: "    zoom:1;"}]
Comment on attachment 794653 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11721

Please find attached a link to the github pull request that fixes this by passing the callback the correct default configuration.
Attachment #794653 - Flags: review?(bfrancis)
Comment on attachment 794653 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11721

Thanks!
Attachment #794653 - Flags: review?(bfrancis) → review+
https://github.com/lissyx/gaia/commit/56f032f0318db222b0f9c34a4ddc2e6552b292f4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Thanks for the patch!
Verified building my own build and commit 5910944bc3cd4a263299431a3832c5582325f393
Status: RESOLVED → VERIFIED
Dale Harvey added a comment in Pivotal Tracker:   
   
This was actually fixed in - https://bugzilla.mozilla.org/show_bug.cgi?id=910011
Blocks: 919515
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: