905845 - REBUILD_CHECK doesn't work on Windows because of the DirectX SDK

Status: RESOLVED WORKSFORME

(Firefox Build System :: General, defect)

Description

[[e-mail]]

I tried using REBUILD_CHECK=1 to troubleshoot bug 905816. However the build failed the first time that the build system wanted to link to the DirectX SDK. This appears to be because the path to the DirectX SDK includes brackets which are disallowed in pymake builtins. Sorry but I didn't take the time to capture the actual error message because some reason clipboard sharing isn't working in my VM at the moment.

Comment 1

[Mike Hommey [:glandium]]

I tried a REBUILD_CHECK=1 build on Windows today, and it worked. Since pymake was involved in this bug report, and since we've stopped using pymake a long time ago now, I'm suspecting this was fixed by stopping to use pymake. Can you confirm? (I am considering enabling REBUILD_CHECK by default)

Comment 2

[[e-mail]]

(In reply to Mike Hommey from comment #1)
> I tried a REBUILD_CHECK=1 build on Windows today, and it worked. Since
> pymake was involved in this bug report, and since we've stopped using pymake
> a long time ago now, I'm suspecting this was fixed by stopping to use
> pymake. Can you confirm? (I am considering enabling REBUILD_CHECK by default)

Well, since this depended on a bug in pymake builtins, and I've never used REBUILD_CHECK since (I just hardcoded $(info $(notdir $@): $(notdir $?)) instead, which works well enough for my purposes), I'll resolve this as WORKSFORME.