gfx/gl/GLConsts.h nits fix.

RESOLVED FIXED in mozilla26

Status

()

Core
Graphics
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Guillaume Abadie, Assigned: Guillaume Abadie)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Pushed gfx/gl/GLConsts.h a little bit to fast.
(Assignee)

Comment 1

4 years ago
Created attachment 791030 [details] [diff] [review]
patch revision 1
Attachment #791030 - Flags: review?(jgilbert)
Comment on attachment 791030 [details] [diff] [review]
patch revision 1

Review of attachment 791030 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLParseRegistryXML.py
@@ +54,5 @@
>                      '#define GLCONSTS_H_',
>                      '',
>                      '/**',
>                      ' * GENERATED FILE, DO NOT MODIFY DIRECTLY.',
> +                    ' * this is a file generated directly from the official OpenGL registry',

s/this/This/

@@ +77,5 @@
>          define = '#define LOCAL_' + lib + '_' + name
> +        whitespace = 60 - len(define)
> +        
> +        if whitespace < 0:
> +            whitespace = whitespace % 4

Let's do %8, since it should line things up better automagically.
Attachment #791030 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 791030 [details] [diff] [review]
> patch revision 1
> 
> Review of attachment 791030 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/gl/GLParseRegistryXML.py
> @@ +54,5 @@
> >                      '#define GLCONSTS_H_',
> >                      '',
> >                      '/**',
> >                      ' * GENERATED FILE, DO NOT MODIFY DIRECTLY.',
> > +                    ' * this is a file generated directly from the official OpenGL registry',
> 
> s/this/This/
Oups... Fixed!
> 
> @@ +77,5 @@
> >          define = '#define LOCAL_' + lib + '_' + name
> > +        whitespace = 60 - len(define)
> > +        
> > +        if whitespace < 0:
> > +            whitespace = whitespace % 4
> 
> Let's do %8, since it should line things up better automagically.
Fixed!
(Assignee)

Comment 4

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/70848736309b
https://hg.mozilla.org/mozilla-central/rev/70848736309b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.