Closed
Bug 905853
Opened 12 years ago
Closed 12 years ago
gfx/gl/GLConsts.h nits fix.
Categories
(Core :: Graphics, enhancement)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: guillaume.abadie, Assigned: guillaume.abadie)
References
Details
Attachments
(1 file)
|
24.29 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Pushed gfx/gl/GLConsts.h a little bit to fast.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #791030 -
Flags: review?(jgilbert)
|
|
||
Comment 2•12 years ago
|
||
Comment on attachment 791030 [details] [diff] [review]
patch revision 1
Review of attachment 791030 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLParseRegistryXML.py
@@ +54,5 @@
> '#define GLCONSTS_H_',
> '',
> '/**',
> ' * GENERATED FILE, DO NOT MODIFY DIRECTLY.',
> + ' * this is a file generated directly from the official OpenGL registry',
s/this/This/
@@ +77,5 @@
> define = '#define LOCAL_' + lib + '_' + name
> + whitespace = 60 - len(define)
> +
> + if whitespace < 0:
> + whitespace = whitespace % 4
Let's do %8, since it should line things up better automagically.
Attachment #791030 -
Flags: review?(jgilbert) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
(In reply to Jeff Gilbert [:jgilbert] from comment #2)
> Comment on attachment 791030 [details] [diff] [review]
> patch revision 1
>
> Review of attachment 791030 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: gfx/gl/GLParseRegistryXML.py
> @@ +54,5 @@
> > '#define GLCONSTS_H_',
> > '',
> > '/**',
> > ' * GENERATED FILE, DO NOT MODIFY DIRECTLY.',
> > + ' * this is a file generated directly from the official OpenGL registry',
>
> s/this/This/
Oups... Fixed!
>
> @@ +77,5 @@
> > define = '#define LOCAL_' + lib + '_' + name
> > + whitespace = 60 - len(define)
> > +
> > + if whitespace < 0:
> > + whitespace = whitespace % 4
>
> Let's do %8, since it should line things up better automagically.
Fixed!
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•