905885 - Log sendchange command in release runner

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Fix typo

Accidental reference to logging module rather than logging instance.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

https://hg.mozilla.org/build/tools/rev/6709ebcca89e

release-runner upgraded and restarted.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

This isn't working for some reason.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [tools] Rearrange a little

Here's a theory, arm your weapons to shoot it down:
1, INFO messages aren't output by default, it has to be WARNING or higher.
2, Early in release-runner we have
     logging.basicConfig(format="%(asctime)s - %(levelname)s - %(message)s")
     log = logging.getLogger(__name__)
   And later in main() there is a setLevel on that log object.
3, Other logging objects are created in imported modules (eg sanity.py for the 
   sendchange), and the setLevel in 2 doesn't act on them (so no INFO shown)

The fix here is to do the basicConfig() call later, when we know what the level should be, and that affects all logging objects. At least it does in a mock up of this situation.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 796528 [details] [diff] [review]
[tools] Rearrange a little

https://hg.mozilla.org/build/tools/rev/d7c75caea5ed

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Updated tools checkout at bm81:/builds/releaserunner/tools.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Unfortunately this is still not working, need to find a way to debug closer to the actual code.

Unrelated follow up to fix a typo in the last patch (top_level instead of log_level):
  https://hg.mozilla.org/build/tools/rev/df3b2dc94840

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

This is working now. I probably needed to restart release runner at comment #5.