905950 - [Messages] Recipient assimilation should only occur when composing a new message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Leo]

1. Title: Unable to send a meesage after sending with multiple recipients by dragging down the 'to' field
2. Precondition: Save some contacts 
3. Tester's Action:  1)Open SMS application
                     2) Add 2~3 recipients in the 'to' field
                     3) Add some text in message field
                     4) Drag down the 'to' field 
                     5)send the message
                     6) Open any previous thread -> add text 
                     7)click on send button -> observe the scenario 
4. Detailed Symptom (ENG.) : The send button is not working and unable to send any message
5. Expected:  The send button should work properly and the user should be able to send a message
6. Reproducibility: Y
1) Frequency Rate : 100%
7. Gaia Master/v1-train: Reproduced on v1-train
8. Gaia Revision:d65666d865b2b1ae686744be7e30c3d737db80a7
9. Personal email id: [e-mail]

Comment 1

[Leo]

The following error is shown after pressing send button
08-16 14:14:09.441: E/GeckoConsole(512): [JavaScript Error: "TypeError: node is null" {file: "app://sms.gaiamobile.org/js/thread_ui.js" line: 385}]

Note:There is no problem if we send a message witout dragging the to filed

Comment 2

[Wayne Chang [:wchang]]

steve, can you check this bug?

Comment 3

[Leo]

Note:
This issue is happening if we try to send a message to the same numbers which we used while sending a message to multiple recipients

Comment 4

[Wayne Chang [:wchang]]

Corey, do you have anyone to check this while steve is on PTO?

I can reproduce this on other devices too.

Comment 5

[:gerard-majax]

I don't get it, the commit you give is not for Gaia v1-train, but Gaia master: https://github.com/mozilla-b2g/gaia/commit/d65666d865b2b1ae686744be7e30c3d737db80a7

The v1-train branch is at https://github.com/mozilla-b2g/gaia/commits/v1-train

Comment 6

[:gerard-majax]

The master commit you point at is from bug 902500. So that might be a regression, but this commit is only on top of master, it has not been uplifted.

Comment 7

[Wayne Chang [:wchang]]

(In reply to Wayne Chang [:wchang] from comment #4)
> Corey, do you have anyone to check this while steve is on PTO?
> 
> I can reproduce this on other devices too.

on gaia commit c9ad2187751a8c312d58c2144afe372e9e0b2694

Comment 8

[Rick Waldron [:rwaldron]]

I'll address this immediately

Comment 9

[Rick Waldron [:rwaldron]]

(In reply to Leo from comment #0)
> 1. Title: Unable to send a meesage after sending with multiple recipients by
> dragging down the 'to' field
> 2. Precondition: Save some contacts 
> 3. Tester's Action:  1)Open SMS application
>                      2) Add 2~3 recipients in the 'to' field
>                      3) Add some text in message field
>                      4) Drag down the 'to' field 
>                      5)send the message
>                      6) Open any previous thread -> add text 
>                      7)click on send button -> observe the scenario 
> 4. Detailed Symptom (ENG.) : The send button is not working and unable to
> send any message
> 5. Expected:  The send button should work properly and the user should be
> able to send a message
> 6. Reproducibility: Y
> 1) Frequency Rate : 100%
> 7. Gaia Master/v1-train: Reproduced on v1-train
> 8. Gaia Revision:d65666d865b2b1ae686744be7e30c3d737db80a7
> 9. Personal email id: [e-mail]

Confirmed

Comment 10

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11580

- Restrict recipient assimilation:
    - Only when in #new view
    - Only when there is a placeholder to inspect

Comment 11

[Corey Frang [:gnarf]]

Comment on attachment 791380 [details]
https://github.com/mozilla-b2g/gaia/pull/11580

r=me - Simple change, so long as the sms part of travis tests passes this LGTM

Comment 12

[Rick Waldron [:rwaldron]]

gaia@master https://github.com/mozilla-b2g/gaia/commit/e8c80f2b443326866897818e3329e8c2e0dd7b8c

gaia@v1-train https://github.com/mozilla-b2g/gaia/commit/d0ea3d0008998f730039c51a5d216abb1fa1e6e9

Comment 13

[Wayne Chang [:wchang]]

Thanks for the quick turn around Rick.

Flagging Tim to uplift to 1.1hd too.

Comment 14

[Julien Wajsberg [:julienw]]

with the correct flag it will get noticed ;)

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: d0ea3d0008998f730039c51a5d216abb1fa1e6e9

Comment 16

[sbogati]

Issue no longer occers on Leo Device. 
Build ID: 20130827041201
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/328b3b8158ee
Gaia: 4b2f1a103d046c92d201e8fcfb1ae224f59e7cf1
Platform Version: 18.1
while opening  previous thread on SMS the send button works as expected.