906001 - Intermittent PROCESS-CRASH | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)][@ JS::Zone::runtimeFromMainThread()] after Assertion failure: CurrentThreadCanAccessRuntime(runtime_), js/src/gc/Zone.h:118

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P3)

Description

[Carsten Book [:Tomcat]]

Rev3 Fedora 12x64 mozilla-inbound debug test mochitest-browser-chrome on 2013-08-16 04:39:13 PDT for push 106dba161a79

slave: talos-r3-fed64-064

https://tbpl.mozilla.org/php/getParsedLog.php?id=26633180&tree=Mozilla-Inbound

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118

Comment 1

[Legacy TBPL/Treeherder Robot]

edmorley
https://tbpl.mozilla.org/php/getParsedLog.php?id=26638914&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-other on 2013-08-16 07:35:58
revision: 0415635dba49
slave: talos-r4-snow-065

ImportError: cannot import name OrderedDict
Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/actions/test_general.xul | Exited with code 1 during test run
PROCESS-CRASH | chrome://mochitests/content/a11y/accessible/tests/mochitest/actions/test_general.xul | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)]
Return code: 256

Comment 2

[Jan de Mooij [:jandem]]

Brian could this be related to bug 897655 maybe? Just a wild guess based on the JS changes that landed recently.

Comment 3

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26648358&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-browser-chrome on 2013-08-16 12:04:42
revision: 3a65a24def34
slave: talos-r4-snow-024

ImportError: cannot import name OrderedDict
Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | Exited with code 1 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)]
Return code: 256

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=26621515&tree=Mozilla-Inbound

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=26630039&tree=Mozilla-Inbound

Comment 6

[Brian Hackett [Laid off!]]

Attachment: potential patch

The stack that I looked at seemed to indicate we were allocating from an atoms zone on which a GC has started.  The atoms zone can't be collected from while off thread parsing is going on, and while we check for this when triggering the parse there isn't anything I can see to prevent the collection from starting while the parse is in progress.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=26641088&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=26649080&tree=Mozilla-Inbound

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 791474 [details] [diff] [review]
potential patch

I thought there was some other way to prevent this, but maybe not.

Comment 9

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=26654951&tree=Mozilla-Inbound
WINNT 6.2 mozilla-inbound debug test mochitest-browser-chrome on 2013-08-16 13:31:47
revision: 9ab1c5795b4f
slave: t-w864-ix-037

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at e:\builds\moz2_slave\m-in-w32-d-0000000000000000000\build\js\src\gc/Zone.h:118
[Child 3884] ###!!! ABORT: ActorDestroy by IPC channel failure at LayerTransactionChild: file e:/builds/moz2_slave/m-in-w32-d-0000000000000000000/build/gfx/layers/ipc/LayerTransactionChild.cpp, line 83
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/toolkit/components/viewsource/test/browser/browser_bug713810.js | Exited with code -2147483645 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/toolkit/components/viewsource/test/browser/browser_bug713810.js | application crashed [@ JS::Zone::runtimeFromMainThread()]
Return code: 1

Comment 10

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6d6c2ac808e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=26666437&tree=Mozilla-Inbound

This is from a push after comment 8 :(

Comment 12

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26663494&tree=Fx-Team
Rev5 MacOSX Mountain Lion 10.8 fx-team debug test mochitest-browser-chrome on 2013-08-16 17:26:04
revision: 734f0dc3958e
slave: talos-mtnlion-r5-080

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | Exited with code 1 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/sessionstore/test/browser_522545.js | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)]
Return code: 256

Comment 13

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26661929&tree=Fx-Team
Windows XP 32-bit fx-team debug test mochitest-other on 2013-08-16 17:09:07
revision: 2c6cf76338b5
slave: t-xp32-ix-060

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at e:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\js\src\gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/chrome/browser/modules/test/chrome/test_sharedframe.xul | Exited with code -2147483645 during test run
PROCESS-CRASH | chrome://mochitests/content/chrome/browser/modules/test/chrome/test_sharedframe.xul | application crashed [@ JS::Zone::runtimeFromMainThread()]
Return code: 1

Comment 14

[Brian Hackett [Laid off!]]

Attachment: round 2

Hmm, there still might be some gaps here, we can trigger an off thread parse when the atoms zone wasGCStarted() or isGCScheduled() but not needsBarrier().  I don't know if that is actually possible, but if it is then this patch should handle the case.  If not, this also adds enough assertions to ensure that we at least bust an assert somewhere else in a spot that should be easier to debug.

Comment 15

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26669224&tree=Fx-Team
Rev4 MacOSX Snow Leopard 10.6 fx-team debug test mochitest-browser-chrome on 2013-08-16 19:40:42
revision: e1210bbb856d
slave: talos-r4-snow-078

ImportError: cannot import name OrderedDict
Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | Exited with code 1 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/browser_privatebrowsing_certexceptionsui.js | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)]
Return code: 256

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d6d6c2ac808e

Comment 17

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26684988&tree=Fx-Team
Windows 7 32-bit fx-team debug test mochitest-browser-chrome on 2013-08-17 09:03:10
revision: 47ce79f94564
slave: t-w732-ix-007

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at e:\builds\moz2_slave\fx-team-w32-d-0000000000000000\build\js\src\gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_bug409481.js | Exited with code -2147483645 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/base/content/test/browser_bug409481.js | application crashed [@ JS::Zone::runtimeFromMainThread()]
Return code: 1

Comment 18

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26686283&tree=Fx-Team
Rev4 MacOSX Snow Leopard 10.6 fx-team debug test mochitest-browser-chrome on 2013-08-17 09:38:59
revision: df040913f3c4
slave: talos-r4-snow-021

ImportError: cannot import name OrderedDict
TypeError: this._windows[aWindow.__SSi] is undefined
TypeError: this._windows[aWindow.__SSi] is undefined
Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at ../../../js/src/gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/test/browser_bug538331.js | Exited with code 1 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/components/test/browser_bug538331.js | application crashed [@ js::gc::ArenaLists::allocateFromArenaInline(JS::Zone*, js::gc::AllocKind)]
Return code: 256

Comment 19

[Legacy TBPL/Treeherder Robot]

philor
https://tbpl.mozilla.org/php/getParsedLog.php?id=26686781&tree=Mozilla-Inbound
Windows 7 32-bit mozilla-inbound debug test mochitest-browser-chrome on 2013-08-17 10:25:33
revision: 2652c7c4e982
slave: t-w732-ix-078

Assertion failure: CurrentThreadCanAccessRuntime(runtime_), at e:\builds\moz2_slave\m-in-w32-d-0000000000000000000\build\js\src\gc/Zone.h:118
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/base/content/test/browser_zbug569342.js | Exited with code -2147483645 during test run
PROCESS-CRASH | chrome://mochitests/content/browser/browser/base/content/test/browser_zbug569342.js | application crashed [@ JS::Zone::runtimeFromMainThread()]
Return code: 1

Comment 20

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 791609 [details] [diff] [review]
round 2

Review of attachment 791609 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. Sorry I didn't catch the fact earlier that needsBarrier is insufficient.

Comment 21

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2fe02ad61d77

Comment 22

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2fe02ad61d77

Comment 23

[Legacy TBPL/Treeherder Robot]

log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=9628702
repository: mozilla-inbound
start_time: 2015-05-06T18:56:28
who: philringnalda[at]gmail[dot]com
machine: t-snow-r4-0150
buildname: Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound debug test mochitest-other
revision: 9110fe02f095

Assertion failure: CurrentThreadCanAccessRuntime(rt), at /builds/slave/m-in-m64-d-0000000000000000000/build/src/js/src/jsgc.cpp:3371
TEST-UNEXPECTED-FAIL | toolkit/components/aboutmemory/tests/test_memoryReporters.xul | application terminated with exit code 1
PROCESS-CRASH | toolkit/components/aboutmemory/tests/test_memoryReporters.xul | application crashed [@ js::GCHelperState::waitForBackgroundThread()]
TEST-UNEXPECTED-FAIL | leakcheck | default process: missing output line for total leaks!
Return code: 1
No tests run or test summary not found

Comment 24

[BMO Automation]

Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.

Comment 25

[Joel Maher ( :jmaher ) (UTC -8)]

why is this leave open?

Comment 26

[Intermittent Failures Robot]

1 failures in 2759 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 1

Platform breakdown:
* osx-10-10: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=906001&startday=2018-10-15&endday=2018-10-21&tree=all