Closed Bug 906004 Opened 11 years ago Closed 6 years ago

Intermittent test_contacts_basics.html | Right sorting order

Categories

(Core Graveyard :: DOM: Contacts, defect, P3)

Product:
Core Graveyard
Component:
DOM: Contacts
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INCOMPLETE

People

(Reporter: emorley, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [leave open])

Attachments

(1 file, 1 obsolete file)

sort-order.diff
1.11 KB, patch
Details | Diff | Splinter Review 
Windows XP 32-bit mozilla-central debug test mochitest-2 on 2013-08-16 03:12:43 PDT for push 6f265af4e3d8

slave: t-xp32-ix-059

https://tbpl.mozilla.org/php/getParsedLog.php?id=26630095&tree=Mozilla-Central

{
03:20:08     INFO -  3590 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Same anniversary
03:20:08     INFO -  3591 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Same sex
03:20:08     INFO -  3592 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Same genderIdentity
03:20:08     INFO -  3593 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Same key
03:20:08     INFO -  3594 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Begin!
03:20:08     INFO -  3595 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | Test sorting with published
03:20:08     INFO -  3596 INFO TEST-PASS | /tests/dom/contacts/tests/test_contacts_basics.html | 3 results
03:20:08     INFO -  3597 ERROR TEST-UNEXPECTED-FAIL | /tests/dom/contacts/tests/test_contacts_basics.html | Right sorting order
}
Assignee: nobody → stully
Attached patch sort-order.diff (obsolete) — — Splinter Review 
The test failure shows a failure on Win XP. This test fails on Android as well since Android does not support published fields so this test should be skipped on Android.
Attachment #791423 - Flags: review?(cpeterson)
Comment on attachment 791423 [details] [diff] [review]
sort-order.diff

Review of attachment 791423 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but someone more familiar with the Contacts tests should review this patch.
Attachment #791423 - Flags: review?(cpeterson) → feedback+
Attachment #791423 - Flags: review?(reuben.bmo)
Comment on attachment 791423 [details] [diff] [review]
sort-order.diff

Review of attachment 791423 [details] [diff] [review]:
-----------------------------------------------------------------

So this is only a partial fix, right? The Windows XP failure remains unfixed.

>Bug 906004 - Intermittent test_contacts_basics.html | Right sorting order
Describe the fix, not the bug. See https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Attachment #791423 - Flags: review?(reuben.bmo) → review+
>So this is only a partial fix, right? The Windows XP failure remains unfixed.

Yes, WinXP is still affected. This is only for Android. I didn't notice this was actually a failure on WinXP until after attaching that patch since I noticed the same problem on Android, but since the tests are currently disabled there, no one else saw it.
Attached patch sort-order.diff — — Splinter Review 
Changed message
Attachment #791423 - Attachment is obsolete: true
Shane: should this bug be kept open for the Windows XP test failure?

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffd64701a996
Status: NEW → ASSIGNED
Flags: needinfo?(stully)
Whiteboard: [leave open]
> Shane: should this bug be kept open for the Windows XP test failure?

Yes
Flags: needinfo?(stully)
Assignee: stully → nobody
Component: DOM: Device Interfaces → DOM: Contacts
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Mass-closing old bugs I filed that have not had recent activity/no longer affect me.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: