906093 - Have goggles projects work with make-valet

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[Jon Buckley [:jbuck]]

The make-valet makes the assumption that the embed shell will be written to S3 with two files, {{url}} and {{url}}_. The goggles currently only publish to {{url}}, so the make-valet gives you a nice 404 page. As a stop-gap we should add _ to the url, and then also add support for contenturl

Comment 1

[Pomax]

adding the _ is not the way to go. We should revert that and as an immediate fix add an exception rule for the goggles in make-valet, so that we don't use the embed shell for goggle projects. 

With this followup: https://bugzilla.mozilla.org/show_bug.cgi?id=906113

Comment 2

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/make-valet/pull/12

Comment 3

[Pomax]

Comment on attachment 792222 [details] [review]
https://github.com/mozilla/make-valet/pull/12

it is delicious

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/make-valet

https://github.com/mozilla/make-valet/commit/267ed2ca5374f09201bd41ae9c986cc2523346d9
Fix bug 906093 - Add support for web xray makes