906097 - Using bootstrap to install the build dependencies on Fedora 19 fails to install gcc-c++

Status: RESOLVED WORKSFORME

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Kevin Brosnan [Ex-Mozilla]]

Used https://developer.mozilla.org/en-US/docs/Simple_Firefox_build/Linux_and_MacOS_build_preparation to bootstrap my new Android development machine on Fedora 19 x64.

Build failed:
 0:00.40 cross compiling from x86_64-unknown-linux-gnu to arm-linux-android
 0:00.40 checking for host c compiler... checking for cc... cc
 0:00.40 cc
 0:00.40 checking for host c++ compiler... checking for c++... no
 0:00.40 checking for g++... no
 0:00.40 checking for clang++... no
 0:00.40 checking for cl... no
 0:00.40 configure: error: no acceptable c++ compiler found in $PATH

Manually ran https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Linux_Prerequisites#RedHat_Enterprise_Linux_%28RHEL%29.2FCentOS.2FFedora 

Build still failed.

After some time chasing red herrings related to the Android setup I came across https://wiki.mozilla.org/Mobile/Fennec/Android_OtherBuildEnvs and ran the yum install command. 

Installing:
gcc-c++        x86_64          4.8.1-1.fc19             fedora                7.1 M


Build now worked.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Looks like yum groupinstall "Development Tools" fails because the package is empty. The replacement is "C Development Tools and Libraries".

https://ask.fedoraproject.org/question/26455/fedora-19-beta1-groupinstall/

Comment 2

[Gregory Szorc [:gps]]

This should be relatively easy to fix. File in question is at /python/mozboot/mozboot/fedora.py (https://hg.mozilla.org/mozilla-central/file/b7f636fada9f/python/mozboot/mozboot/fedora.py).

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Attachment: add 'C Development Tools and Libraries' to fedora.py

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 792432 [details] [diff] [review]
add 'C Development Tools and Libraries' to fedora.py

Review of attachment 792432 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozboot/mozboot/fedora.py
@@ +17,5 @@
>          self.yum_groupinstall(
>              'Development Tools',
>              'Development Libraries',
> +            'GNOME Software Development',
> +            'C Development Tools and Libraries')

Will the new group package install on older Fedora releases? If not, this needs to be behind a conditional.

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 792432 [details] [diff] [review]
add 'C Development Tools and Libraries' to fedora.py

Cancelling review until Kevin provides more info.

While we were talking about this in real life, I came up with the idea of checking Vagrantfile's into the tree to help test the bootstrapper. It would be rad if we could launch a fresh distro in a VM, perform the bootstrap, and verify |mach configure| will work post-bootstrap. We likely wouldn't get this tested on release automation (at least not yet). But I could certainly throw it up on my personal Jenkins instance.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Bootstrap installs the correct things these days.