906154 - move gCategoryImp to its point of use to avoid a static constructor

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: move gCategoryImp to its point of use to avoid a static constructor

No reason that we need to initialize this until someone asks for it.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I'd have considered using the module constructor and destructor rather than function scope statics (which I think aren't great either, though not sure what the compiler generated code for them looks like these days).  But maybe this is an improvement anyway.)

Comment 3

[Simon Montagu :smontagu]

Is this interface even used any more? I think it's now only some vestigial remnants after having its functionality replaced by mozilla::unicode

Comment 4

[Nathan Froyd [:froydnj]]

Ping to smontagu and jfkthame....

Comment 5

[Jonathan Kew [:jfkthame]]

Huh, sorry - I thought I'd responded to this, but apparently that was only in my head. :(

AFAIK, this is no longer used anywhere in Gecko or Firefox, as we use the COM-free mozilla::unicode functions directly.

However, it's possible that there is external code (e.g. addons, or maybe front-end code in other apps such as Thunderbird) that relies on it, so I'd be hesitant to remove it completely without further investigation.

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 791438 [details] [diff] [review]
move gCategoryImp to its point of use to avoid a static constructor

Review of attachment 791438 [details] [diff] [review]:
-----------------------------------------------------------------

So if we aren't going to remove the interface this is presumably a worthwhile improvement

Comment 7

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d6357352d724

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d6357352d724