Closed Bug 906177 Opened 11 years ago Closed 7 years ago

Make bootstrap compatible with Elementary OS

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla26
Tracking Status
firefox55 --- fixed

People

(Reporter: jsbruner, Assigned: bugzilla, Mentored)

References

()

Details

(Whiteboard: [lang=python][os=linux])

Attachments

(3 files)

Elementary OS 0.2. Elementary OS is an Debian-based Linux OS that is currently not supported by the bootstrap file/command.

Elementary OS works almost exactly like Ubuntu, so adding support should be very simple. I assume it's just a matter of adding some profile item.

I would be happy to help in any way if any kind of testing/info is needed for the platform.

Link to the OS site in the summary.
Terminal Output:

"Trackback (most recent call last):
  File "bootstrap.py" line 142, in <module>
    sys.exit(main(sys.argv))
  File "bootstrap.py", line 133, in main
    dasboot.bootstrap()
  File "/tmp/tmpdph98n/mozboot/bootstrap.py", line 56, in bootstrap
    url = repo_url + '/raw-file/default/python/mozboot/' + path
 NoteImplementedError: Bootstrap support for this Linux distro not yet available."
Bootstrap for additional operating systems is always desired. However, support tends to be provided by people who want it.

If you want to have a go at this, the code lives in mozilla-central at /python/mozboot. You just need a new Python module for Elementary OS and to hook it up in bin/bootstrap.py and mozboot/bootstrap.py.
Whiteboard: [mentor=gps][lang=python][os=linux]
(In reply to Gregory Szorc [:gps] from comment #2)
> If you want to have a go at this, the code lives in mozilla-central at
> /python/mozboot. You just need a new Python module for Elementary OS and to
> hook it up in bin/bootstrap.py and mozboot/bootstrap.py.

If (someone) wants to add bootstrap support for non-mainstream linux distros, we'd better start *not* requiring a new module for each distro. Because we'll end up with hundreds of them.
If Elementary OS is based on Ubuntu, this should work.Please review.
Attachment #795161 - Flags: review?(gps)
(In reply to Mike Hommey [:glandium] from comment #3)
> (In reply to Gregory Szorc [:gps] from comment #2)
> > If you want to have a go at this, the code lives in mozilla-central at
> > /python/mozboot. You just need a new Python module for Elementary OS and to
> > hook it up in bin/bootstrap.py and mozboot/bootstrap.py.
> 
> If (someone) wants to add bootstrap support for non-mainstream linux
> distros, we'd better start *not* requiring a new module for each distro.
> Because we'll end up with hundreds of them.

Let's cross that bridge when we get to it. Maybe 1 or 2 more until we lay down the law.
Comment on attachment 795161 [details] [diff] [review]
Added Elementary to bootstrap.py

Review of attachment 795161 [details] [diff] [review]:
-----------------------------------------------------------------

Is that it? This was easy!
Attachment #795161 - Flags: review?(gps) → review+
Sheriff: Can commit with DONTBUILD (NPOTB).

Thanks for the patch! This will automatically get committed to source control within a day.
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1f8917c1e692
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
I am trying to run the bootstrap.py command on Elementary OS Luna but I am getting an error "Bootstrap support for this Linux distro not yet available."
This is the command I ran. 
wget -O bootstrap.py https://hg.mozilla.org/mozilla-central/raw-file/default/python/mozboot/bin/bootstrap.py && python bootstrap.py

Executing bootstrap.py residing in /mozilla-central/python/mozboot/mozboot gives the following error:
ImportError: No module named mozboot.centos
Status: RESOLVED → REOPENED
Flags: needinfo?(ryanvm)
Resolution: FIXED → ---
Flags: needinfo?(josiah)
Flags: needinfo?(ryanvm)
I stopped using Elementary many months ago unfortunately, but I should still have the .iso around somewhere, so I'll re-install and check what the status is here.

(I'm assuming that's what the needinfo was for, but am not really sure)
Flags: needinfo?(josiah)
Assignee: josiah → info
platform.linux_distribution() returns "elementary OS" (in double quotes). I added the string to the possible range.

./mach bootstrap worked successfull without errors
Mentor: gps
Whiteboard: [mentor=gps][lang=python][os=linux] → [lang=python][os=linux]
Attachment #8524001 - Flags: review?(gps)
Comment on attachment 8524001 [details] [diff] [review]
bug1057305-fix-bootstrap-on-elementary.patch

Review of attachment 8524001 [details] [diff] [review]:
-----------------------------------------------------------------

What weird behavior!

Thanks for the patch.

I'll land this for you.
Attachment #8524001 - Flags: review?(gps) → review+
https://hg.mozilla.org/mozilla-central/rev/1fe4af5711ac
Status: REOPENED → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Hi, this issue still exists with new version(Luna) of Elementary OS. The distro name output has now `e` i lowercase that's why it throws NotImplementedError on new version of Elemenatary OS. Please checkout - http://pasteboard.co/MQuAGpYJe.png. I am adding a patch that will probably remove this issue.
*the distro name is "elementary"
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 8850487 [details]
Bug 906177 - Added distro support for Elementary OS Luna;

https://reviewboard.mozilla.org/r/123088/#review125508

Looks good! Thanks for contributing the fix! I'll land this for you. There's nothing more you need to do.

Also, next time, please open a new bug instead of submitting a review against an old, closed bug because it violates some workflow assumptions. The tools should probably warn about this and I can't really fault you for not knowing about Mozilla's special snowflake workflows on your first contribution. It's our fault for not making the contribution process more robust.
Attachment #8850487 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b2320a76215
Added distro support for Elementary OS Luna;r=gps
Thanks. I will keep that in mind.(In reply to Gregory Szorc [:gps] from comment #19)
> Comment on attachment 8850487 [details]
> Bug 906177 - Added distro support for Elementary OS Luna;
> 
> https://reviewboard.mozilla.org/r/123088/#review125508
> 
> Looks good! Thanks for contributing the fix! I'll land this for you. There's
> nothing more you need to do.
> 
> Also, next time, please open a new bug instead of submitting a review
> against an old, closed bug because it violates some workflow assumptions.
> The tools should probably warn about this and I can't really fault you for
> not knowing about Mozilla's special snowflake workflows on your first
> contribution. It's our fault for not making the contribution process more
> robust.

Thanks. I will keep that in mind.
https://hg.mozilla.org/mozilla-central/rev/9b2320a76215
Status: REOPENED → RESOLVED
Closed: 10 years ago7 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.