906200 - Tweak pager options to work better with colour

Status: RESOLVED FIXED

(Firefox Build System :: MozillaBuild, task)

Description

[[e-mail]]

The latest release of mozillabuild enabled the colour extension. This only works under MSYS because it detects the TERM environment variables, which make it output ANSI colour codes, which less -R then outputs, which MSYS then turns into colours.

Unfortunately the configured attend pager option provided excludes some commands whose output is coloured. These commands need to have pager enabled for the colour to work correctly. The easiest fix is to provide an empty attend option, so that everything is output through less. As we're using less -F it quits automatically if the output is less than a whole page, so there's no difference in behaviour in trivial cases.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

This is all pretty foreign to me and I'm not entire sure I'm grasping what is that needs doing here.

Comment 2

[[e-mail]]

> The easiest fix is to provide an empty attend option

Actually it turns out that's a bad idea, since it breaks any option that reads input, such as update, qrefresh, push, pull, commit or transplant.

(In reply to Ryan VanderMeulen from comment #1)
> This is all pretty foreign to me and I'm not entire sure I'm grasping what
> is that needs doing here.

I guess I need to find those commands that are coloured but not paged.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Pretty sure this is fixed by way of the patches gps submitted upstream that are due to ship with hg 3.4+ - see attachment 8560747 [details] [diff] [review]. We're also going to be including the patched version of the color & pager extensions with MozillaBuild 2.0.

If you don't mind, can you try out the test build below and see if it works like you'd expect?
http://people.mozilla.org/~rvandermeulen/MozillaBuildSetup2.0.0pre3.exe

Comment 4

[[e-mail]]

(In reply to Ryan VanderMeulen from comment #3)
> Pretty sure this is fixed by way of the patches gps submitted upstream that
> are due to ship with hg 3.4+ - see attachment 8560747 [details] [diff] [review]. We're also going to be
> including the patched version of the color & pager extensions with MozillaBuild 2.0.
Aha, that does look useful, as then it you can set it to use win32 colour except when paging is active in which case you make it use ansi colour and everything works.

Comment 5

[[e-mail]]

(In reply to Ryan VanderMeulen from comment #3)
> If you don't mind, can you try out the test build below and see if it works
> like you'd expect?
> http://people.mozilla.org/~rvandermeulen/MozillaBuildSetup2.0.0pre3.exe

It fails to check out Thunderbird because there's no hg executable.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

How are you trying to checkout Thunderbird?

On a fresh VM, when I install it and run start-msvc*.bat, I can hg clone https://hg.mozilla.org/comm-central just fine.

Comment 7

[[e-mail]]

Yes, but then you need to run python client.py checkout

Comment 8

[Ryan VanderMeulen [:RyanVM]]

OK, so this is probably the same issue as bug 545432 comment 40. Thanks for testing!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Calling this fixed by bug 545432. I've filed bug 1131048 for fixing up the client.py issue you encountered.