Closed Bug 906226 Opened 8 years ago Closed 8 years ago

Contacts: Move shared test code into a common file

Categories

(Core Graveyard :: DOM: Contacts, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S1 (14feb)

People

(Reporter: reuben, Assigned: reuben)

Details

(Whiteboard: [qa-], [systemsfe])

Attachments

(1 file, 1 obsolete file)

Right now we have a bunch of duplicated code across our tests for comparing contact objects, setting up things, running async tests, etc. See the files in https://mxr.mozilla.org/mozilla-central/source/dom/settings/tests/

We should move them into a shared file that can be imported by the tests. I plan to do this eventually, but until I have the time I can mentor this bug as well.
Rafael is working on this.
Assignee: nobody → rafa.oliveirap
Component: DOM: Device Interfaces → DOM: Contacts
Rafael has been busy with other stuff, and I'm touching these files in bug 942631 so I'm stealing this.
Assignee: rafa.oliveirap → reuben.bmo
Status: NEW → ASSIGNED
Whiteboard: [lang=js][mentor=reuben]
Passes locally, pushed to try here: https://tbpl.mozilla.org/?tree=Try&rev=61620a4b760d

 10 files changed, 438 insertions(+), 1412 deletions(-)

\o/
Attachment #8341992 - Flags: review?(anygregor)
Ah, good old search-and-replace right before you put the patch on Bugzilla. I don't even know why I bother asking for review on v1s anymore…

New try run: https://tbpl.mozilla.org/?tree=Try&rev=8ea6b57d8b27
Attachment #8341992 - Attachment is obsolete: true
Attachment #8341992 - Flags: review?(anygregor)
Attachment #8341993 - Flags: review?(anygregor)
Comment on attachment 8341993 [details] [diff] [review]
Move common code to shared.js and use it in the tests, v2

Review of attachment 8341993 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8341993 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/d997913037df
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Whiteboard: [qa-] → [qa-], [systemsfe]
Target Milestone: mozilla28 → 1.4 S1 (14feb)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.