906240 - cl.py doesn't put the source file in .deps/, and doesn't canonicalize paths

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

gcc -M does output the source file as a dependency, which cl.py doesn't. Bug 905973 relies on the source to be there.

While looking at the above, I also noticed that cl.py is not canonicalizing paths, and outputs different forms of the same paths in different .pp files in the same directory. Like forward vs. backward slash, and normal case vs. lower case (as in c:/Users vs. c:/users)

This likely conflates the number of dependencies checked by pymake.

Comment 1

[Mike Hommey [:glandium]]

Another one: cl.py is exercising the worst in pymake because of how it lays out dependencies.

It uses a:
target: header1
target: header2
target: header3
header1:
header2:
header3:

scheme that makes pymake extra slow (the problem being one target rule per header)
Changing that to:
target: \
header1 \
header2 \
header3
header1:
header2:
header3:

made a no-op "make -C objdir/gfx/layers Compository.obj" 20% faster for me (from 3.5s to 2.7s).

Comment 2

[Mike Hommey [:glandium]]

Attachment: Adapt cl.py dependency output to pymake deficiencies ; also add source file to the list of dependencies

This makes pymake -C objdir/gfx/layers Compositor.obj go down from 3.5s to 2.5s in my vm (path normalization added to the speed-up from comment 1).

Comment 3

[(not currently active) Ted Mielczarek]

More reason to write a Python module to write out dependencies, eh?

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 791602 [details] [diff] [review]
Adapt cl.py dependency output to pymake deficiencies ; also add source file to the list of dependencies

Review of attachment 791602 [details] [diff] [review]:
-----------------------------------------------------------------

It would be really nice if we had a module/shared function for writing make dependency files...

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57f4731f0a86

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57f4731f0a86

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr24/rev/bfb57753afb7