906260 - Bug 904979 broke B2G manufacturer builds (which have MOZILLA_OFFICIAL=1 to enable crash reporter)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Robert Kaiser]

Bug 904979 required people to set --enable-release when MOZILLA_OFFICIAL is on.

Because of http://mxr.mozilla.org/mozilla-central/source/webapprt/application.ini.in#25 we tell all manufacturers to turn on MOZILLA_OFFICIAL (and have bug 884267 open to do that by default or turn on crash reporter by default in some other way).

Due to those two cases, the B2G manufacturer builds (of our partners and Geeksphone) are broken on trunk right now.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Make MOZILLA_OFFICIAL turn --enable-release on automatically

Still allow MOZILLA_OFFICIAL + --disable-release

To whoever comes first.

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 791610 [details] [diff] [review]
Make MOZILLA_OFFICIAL turn --enable-release on automatically

Somehow bzexport won't take three reviewers

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bbd35977478e

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bbd35977478e