906272 - Something is not right with the cycle collection of nsScreen

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Andrew McCreight [:mccr8]]

nsScreen.h has this:

107   NS_DECL_CYCLE_COLLECTION_CLASS_INHERITED(nsScreen,
108                                            nsDOMEventTargetHelper)

...but then doesn't declare anything else related to the cycle collector, like Traverse or Unlink methods, nor does it QI correctly to its undefined participant.

I'm not sure what the right thing to do is here.  It has an nsRefPtr<FullScreenEventListener>, which is a locally defined subclass of  nsIDOMEventListener.  Does the CC need to be told about that field?  If yes, CC definitions need to be added.  If not, the CC declaration can be removed.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

(In reply to Andrew McCreight [:mccr8] from comment #0)
> Does the CC need to be told about that field?

FullScreenEventListener doesn't hold refs to anything so no, it doesn't look like it does.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: remove it

Comment 3

[Andrew McCreight [:mccr8]]

try: https://tbpl.mozilla.org/?tree=Try&rev=fe03c887b3fc

Comment 4

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f4dd0b3b943

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6f4dd0b3b943