Work - Move productization (p12n) options into a separate region.properties file

RESOLVED FIXED in Firefox 26

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: flod, Assigned: flod)

Tracking

({intl})

unspecified
Firefox 26
x86
Windows 8.1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [preview] feature=work)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Currently Firefox for Metro stores p12n information (default search engine, search engine order) inside browser.properties

http://hg.mozilla.org/l10n-central/it/file/d4bcc880e4ac/browser/metro/chrome/browser.properties

browser.search.defaultenginename = Google
browser.search.order.1 = Google
browser.search.order.2 = Yahoo
browser.search.order.3 = Bing

All other Mozilla products store this information in a separate file called region.properties

Example for Firefox
http://hg.mozilla.org/l10n-central/it/file/d4bcc880e4ac/browser/chrome/browser-region/region.properties

All p12n changes to localized versions of Firefox must be approved before landing. Having this information in a separate file would help ensure that changes are explicitly approved by l10n-drivers and would comply with localization tools that let exclude certain files from automatic export. 

See for example the same file for en-GB
http://hg.mozilla.org/l10n-central/en-GB/file/b106e8e68bf9/browser/chrome/browser-region/region.properties

# LOCALIZATION NOTE: REVIEW_REQUIRED
# Please do not commit any changes to this file without a review from
# the l10n-drivers team (this includes en-US). In order to get one,
# please file a bug, add the "productization" keyword and CC l10n@mozilla.com.

Updated

5 years ago
Whiteboard: [preview]
(Assignee)

Comment 1

5 years ago
Created attachment 791684 [details] [diff] [review]
Patch moving p12n to region.properties

The patch seems trivial, unless I overlooked something important in the code.
Attachment #791684 - Flags: review?(mbrubeck)
Attachment #791684 - Flags: feedback?(l10n)
Comment on attachment 791684 [details] [diff] [review]
Patch moving p12n to region.properties

Review of attachment 791684 [details] [diff] [review]:
-----------------------------------------------------------------

I think the wording for en-US is a bit strong, but I think we should strive for something that gets us CCed on en-US bugs, and endorses a localization strategy.

Something like

If you're changing the en-US copy of this file, CC l10n@mozilla.com and help us figure out how to localize the change.

We'll also need to get these strings into filter.py, so that we can have different amounts of search engine orders.
Attachment #791684 - Flags: feedback?(l10n) → feedback+
(Assignee)

Comment 3

5 years ago
Something like this could work?

# LOCALIZATION NOTE: REVIEW_REQUIRED
# For all locales: please do not commit any changes to this file without a
# review from the l10n-drivers team. In order to get one, please file a bug,
# add the "productization" keyword and CC l10n@mozilla.com.
# en-US: if you're changing this file, please CC l10n@mozilla.com in the
# associated bug to help us determine if these changes are relevant for other
# locales and how to localize them.
Comment on attachment 791684 [details] [diff] [review]
Patch moving p12n to region.properties

Review of attachment 791684 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  The proposed text from comment 3 looks good too.

If you land this, please land it on the fx-team branch to minimize risk of merge conflicts with other /browser/metro patches landing there.
Attachment #791684 - Flags: review?(mbrubeck) → review+
Assignee: nobody → francesco.lodolo
Blocks: 852263
Status: NEW → ASSIGNED
Keywords: intl
Summary: Move productization (p12n) options into a separate region.properties file → Work - Move productization (p12n) options into a separate region.properties file
Whiteboard: [preview] → [preview] feature=work
(Assignee)

Comment 5

5 years ago
Created attachment 791770 [details] [diff] [review]
Patch with updated localization comment

Marking previous patch as obsolete to avoid confusion, carrying over r=mbrubeck and f=pike from the previous one.

@Matt
I don't have commit access to non l10n repositories, so someone should land this patch in fx-team in my place. I didn't set checkin-needed because I didn't want to land this on the wrong branch.
Attachment #791684 - Attachment is obsolete: true
Flags: needinfo?(mbrubeck)
https://hg.mozilla.org/mozilla-central/rev/91ff451693ed
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
(Assignee)

Updated

5 years ago
Blocks: 907146
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.