906318 - Work - Move productization (p12n) options into a separate region.properties file

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Francesco Lodolo [:flod]]

Currently Firefox for Metro stores p12n information (default search engine, search engine order) inside browser.properties

http://hg.mozilla.org/l10n-central/it/file/d4bcc880e4ac/browser/metro/chrome/browser.properties

browser.search.defaultenginename = Google
browser.search.order.1 = Google
browser.search.order.2 = Yahoo
browser.search.order.3 = Bing

All other Mozilla products store this information in a separate file called region.properties

Example for Firefox
http://hg.mozilla.org/l10n-central/it/file/d4bcc880e4ac/browser/chrome/browser-region/region.properties

All p12n changes to localized versions of Firefox must be approved before landing. Having this information in a separate file would help ensure that changes are explicitly approved by l10n-drivers and would comply with localization tools that let exclude certain files from automatic export. 

See for example the same file for en-GB
http://hg.mozilla.org/l10n-central/en-GB/file/b106e8e68bf9/browser/chrome/browser-region/region.properties

# LOCALIZATION NOTE: REVIEW_REQUIRED
# Please do not commit any changes to this file without a review from
# the l10n-drivers team (this includes en-US). In order to get one,
# please file a bug, add the "productization" keyword and CC [e-mail].

Comment 1

[Francesco Lodolo [:flod]]

Attachment: Patch moving p12n to region.properties

The patch seems trivial, unless I overlooked something important in the code.

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 791684 [details] [diff] [review]
Patch moving p12n to region.properties

Review of attachment 791684 [details] [diff] [review]:
-----------------------------------------------------------------

I think the wording for en-US is a bit strong, but I think we should strive for something that gets us CCed on en-US bugs, and endorses a localization strategy.

Something like

If you're changing the en-US copy of this file, CC [e-mail] and help us figure out how to localize the change.

We'll also need to get these strings into filter.py, so that we can have different amounts of search engine orders.

Comment 3

[Francesco Lodolo [:flod]]

Something like this could work?

# LOCALIZATION NOTE: REVIEW_REQUIRED
# For all locales: please do not commit any changes to this file without a
# review from the l10n-drivers team. In order to get one, please file a bug,
# add the "productization" keyword and CC [e-mail].
# en-US: if you're changing this file, please CC [e-mail] in the
# associated bug to help us determine if these changes are relevant for other
# locales and how to localize them.

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 791684 [details] [diff] [review]
Patch moving p12n to region.properties

Review of attachment 791684 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!  The proposed text from comment 3 looks good too.

If you land this, please land it on the fx-team branch to minimize risk of merge conflicts with other /browser/metro patches landing there.

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Patch with updated localization comment

Marking previous patch as obsolete to avoid confusion, carrying over r=mbrubeck and f=pike from the previous one.

@Matt
I don't have commit access to non l10n repositories, so someone should land this patch in fx-team in my place. I didn't set checkin-needed because I didn't want to land this on the wrong branch.

Comment 6

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/fx-team/rev/91ff451693ed

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/91ff451693ed