906350 - WinUtils Initialize() checks the return result of LoadLibrary using the wrong value

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/widget/windows/WinUtils.cpp#76

Should be

if (uintptr_t(sDwmDll)) {

Comment 1

[Emanuel Hoogeveen [:ehoogeveen]]

Is the cast even needed? I'm pretty sure HMODULE is just a void pointer under the hood.

Comment 2

[Masatoshi Kimura [:emk]]

> // MSDN: "If the function succeeds, the return value is greater than 31."
Where in MSDN? I was unable to find the statement at least here:
http://msdn.microsoft.com/library/ms684175.aspx

Comment 3

[Brian R. Bondy [:bbondy]]

Was probably confusion with ShellExecute
http://msdn.microsoft.com/en-us/library/windows/desktop/bb762153%28v=vs.85%29.aspx

Comment 4

[Avi Halachmi (:avih)]

Attachment: Check that LoadLibraryW is non-null rather than >31

Comment 5

[Avi Halachmi (:avih)]

Attachment: Forgot to removed the comment about >31

It seems that all around the code we either check LoadLibraryW for non-null, or just go ahead with GetProcAddress without checking, and count on it to return null if the HMODULE is invalid.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 795190 [details] [diff] [review]
Forgot to removed the comment about >31

Review of attachment 795190 [details] [diff] [review]:
-----------------------------------------------------------------

I think I was looking at http://msdn.microsoft.com/en-us/library/windows/desktop/ms684183%28v=vs.85%29.aspx

Comment 7

[Avi Halachmi (:avih)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6fa04f0c9e

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a6fa04f0c9e