Closed Bug 906387 Opened 11 years ago Closed 11 years ago

Intermittent ggc testGeneratorDieButScopeAlive.js | --ion-eager: /builds/slave/m-cen_l64-d_sm-ggc-00000000000/src/js/src/jit-test/tests/basic/testGeneratorDieButScopeAlive.js:16:36 warning: ....................................^

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla26
Tracking Flags:
Tracking Status
firefox24 --- unaffected
firefox25 --- unaffected
firefox26 --- fixed

People

(Reporter: philor, Assigned: jonco)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

hash-hang
3.10 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=26693395&tree=Mozilla-Central#error0
Linux x86-64 mozilla-central leak test spidermonkey_tier_1-generational build on 2013-08-17 19:49:20 PDT for push bb269dc27eab
slave: bld-linux64-ec2-386

TIMEOUT - /builds/slave/m-cen_l64-d_sm-ggc-00000000000/src/js/src/jit-test/tests/basic/testGeneratorDieButScopeAlive.js
TEST-UNEXPECTED-FAIL | /builds/slave/m-cen_l64-d_sm-ggc-00000000000/src/js/src/jit-test/tests/basic/testGeneratorDieButScopeAlive.js | --ion-eager: /builds/slave/m-cen_l64-d_sm-ggc-00000000000/src/js/src/jit-test/tests/basic/testGeneratorDieButScopeAlive.js:16:36 warning: ....................................^
Assignee: general → jcoppeard
Attached patch hash-hang — — Splinter Review 
It turns out that when we rekey hash tables because of moving GC things, we don't allow them to rehash if necessary.

This means they can end up full of removed entries, which causes lookup to loop forever (I think it assumes there is always at least one free entry).

This patch fixes this by checking on every rekey.
Attachment #796796 - Flags: review?(terrence)
Comment on attachment 796796 [details] [diff] [review]
hash-hang

Review of attachment 796796 [details] [diff] [review]:
-----------------------------------------------------------------

I really, really thought we had fixed this specific issue already. I guess not. In any case, great find!
Attachment #796796 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/3a95e61649a4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: