906445 - crash in mozilla::layers::DeprecatedTextureHostDXGID3D11::UpdateImpl(mozilla::layers::SurfaceDescriptor const&, nsIntRegion*, nsIntPoint*)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Jim Mathies [:jimm]]

https://crash-stats.mozilla.com/report/list?product=MetroFirefox&range_value=7&range_unit=days&date=2013-08-18&signature=mozilla%3A%3Alayers%3A%3ADeprecatedTextureHostDXGID3D11%3A%3AUpdateImpl%28mozilla%3A%3Alayers%3A%3ASurfaceDescriptor+const%26%2C+nsIntRegion*%2C+nsIntPoint*%29&version=MetroFirefox%3A26.0a1

0 	xul.dll 	mozilla::layers::DeprecatedTextureHostDXGID3D11::UpdateImpl(mozilla::layers::SurfaceDescriptor const &,nsIntRegion *,nsIntPoint *) 	gfx/layers/d3d11/TextureD3D11.cpp
1 	xul.dll 	mozilla::layers::ContentHostDoubleBuffered::UpdateThebes(mozilla::layers::ThebesBufferData const &,nsIntRegion const &,nsIntRegion const &,nsIntRegion *) 	gfx/layers/composite/ContentHost.cpp
2 	xul.dll 	mozilla::layers::CompositableParentManager::ReceiveCompositableUpdate(mozilla::layers::CompositableOperation const &,std::vector<mozilla::layers::EditReply,std::allocator<mozilla::layers::EditReply> > &) 	gfx/layers/ipc/CompositableTransactionParent.cpp
3 	xul.dll 	mozilla::layers::LayerTransactionParent::RecvUpdate(nsTArray<mozilla::layers::Edit> const &,mozilla::layers::TargetConfig const &,bool const &,nsTArray<mozilla::layers::EditReply> *) 	gfx/layers/ipc/LayerTransactionParent.cpp
4 	xul.dll 	Pickle::ReadBool(void * *,bool *) 	ipc/chromium/src/base/pickle.cc
5 	dxgi.dll 	CDXGISwapChain::Present(unsigned int,unsigned int) 	
6 	mozglue.dll 	arena_dalloc_small 	memory/mozjemalloc/jemalloc.c
7 	mozglue.dll 	arena_dalloc 	memory/mozjemalloc/jemalloc.c
8 	mozglue.dll 	arena_ralloc 	memory/mozjemalloc/jemalloc.c
9 	xul.dll 	std::vector<mozilla::ipc::RPCChannel::RPCFrame,std::allocator<mozilla::ipc::RPCChannel::RPCFrame> >::push_back(mozilla::ipc::RPCChannel::RPCFrame &&) 	c:/tools/msvs10/vc/include/vector
10 	xul.dll 	mozilla::ipc::SyncChannel::OnDispatchMessage(IPC::Message const &) 	ipc/glue/SyncChannel.cpp
11 	xul.dll 	MessageLoop::RunTask(Task *) 	ipc/chromium/src/base/message_loop.cc
12 	xul.dll 	MessageLoop::DoWork() 	ipc/chromium/src/base/message_loop.cc
13 	xul.dll 	base::MessagePumpDefault::Run(base::MessagePump::Delegate *) 	ipc/chromium/src/base/message_pump_default.cc
14 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc
15 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc
16 	xul.dll 	base::Thread::ThreadMain() 	ipc/chromium/src/base/thread.cc
17 	xul.dll 	`anonymous namespace'::ThreadFunc(void *) 	tools/profiler/platform-win32.cc
18 	kernel32.dll 	BaseThreadInitThunk 	
19 	ntdll.dll 	__RtlUserThreadStart 	
20 	ntdll.dll 	_RtlUserThreadStart

Comment 1

[Nick Cameron [:nrc]]

Looks like the call to OpenSharedResource is failing and so mTextures[0] is null. I don't know why that would happen. The msdn page (http://msdn.microsoft.com/en-us/library/windows/desktop/ff476531%28v=vs.85%29.aspx) doesn't suggest any reason for intermittent failure. Another possibility is that we are just passing around a null or bad handle to the texture.

jimm - do you recall what you were doing when the crash happened?

Comment 2

[Nick Cameron [:nrc]]

Also, has this happened recently? Nothing in the last ten days in the crash stats so maybe something else we've done has fixed it.

Comment 4

[Jim Mathies [:jimm]]

(In reply to Nick Cameron [:nrc] from comment #1)
> Looks like the call to OpenSharedResource is failing and so mTextures[0] is
> null. I don't know why that would happen. The msdn page
> (http://msdn.microsoft.com/en-us/library/windows/desktop/ff476531%28v=vs.
> 85%29.aspx) doesn't suggest any reason for intermittent failure. Another
> possibility is that we are just passing around a null or bad handle to the
> texture.
> 
> jimm - do you recall what you were doing when the crash happened?

I filed this off crashstats, I haven't reproduced.

(In reply to Nick Cameron [:nrc] from comment #2)
> Also, has this happened recently? Nothing in the last ten days in the crash
> stats so maybe something else we've done has fixed it.

Yep, looks like it went away on 8/23.

Comment 5

[Nick Cameron [:nrc]]

Attachment: don't assume OpenSharedResource always suceeds

Some speculative guarding against crashing if this situation occurs in the future.

Comment 6

[Bas Schouten (:bas.schouten)]

Comment on attachment 796884 [details] [diff] [review]
don't assume OpenSharedResource always suceeds

Review of attachment 796884 [details] [diff] [review]:
-----------------------------------------------------------------

I don't really object to this but we should -really- find out why this happens. Also, check the return code of OpenSharedSource SUCCEEDED as well as checking the texture to be !NULL.

Comment 7

[Nick Cameron [:nrc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca1ff26fc797

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ca1ff26fc797