906529 - [Buri][Call Log] Device doesn't log unknown numbers

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

Firefox os  v1.1
 Mozilla build ID:20130806071254
 
 DEFECT DESCRIPTION: Device is not showing "unknow numbers" in call log. If you arrange to receive call from call which did activation of CLIR you will see that after answer or reject the call, phone is not showing the "unknow number" in logs.
 
  EXPECTED BEHAVIOUR: Device must show "Unknow number" in call log.
 
  REPRODUCING PROCEDURES:
 1.- From phone A do a call doing CLIR to Fire Fox (phone B), it means, device must dial #31#firefoxphonenumber example:
 #31#3310555201
 2.- Answer the call.
 3.- Go to "Call Log" and you will noticed there is not "Call Log" about received call with "unknow number". 
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT: Wrong Interface.
 
  REPRODUCING RATE:100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Seems like a dup of bug 893927? Although *67 rather than #31# is used there..

Comment 2

[Peter Dolanjski [:pdol]]

Not blocking like 893927

Comment 3

[Mingming ZHAO]

Hi Peter,

I think this is a bug in call log.

In call_log_db.js, there is no code to execute the case of "number == null" (https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/communications/dialer/js/call_log_db.js#L680)

So the "Withheld Number" does not be saved in call log database, of course it can not be displayed in call log.

Additional, another question, once the "Withheld Number" displayed in call log, when user click it, how to display the prompt? (current behavior is prompt the "call", "create new contact", and "add to exiting contact" dialog)

Comment 4

[Mingming ZHAO]

Hi, the critical issue is this "Withheld Number" even can not be displayed in call log.Please check, thanks a lot!

Comment 5

[Mingming ZHAO]

I have a patch, hope it can help you.

--- a/apps/communications/dialer/js/call_log_db.js
+++ b/apps/communications/dialer/js/call_log_db.js
@@ -540,8 +540,16 @@ var CallLogDBManager = {
    * Helper function to get the group ID from a recent call object.
    */
   _getGroupId: function getGroupId(recentCall) {
-    var groupId = [Utils.getDayDate(recentCall.date),
-                   recentCall.number, recentCall.type];
+    var groupId = [];
+    if (recentCall.number) {
+      groupId = [Utils.getDayDate(recentCall.date),
+        recentCall.number, recentCall.type];
+    } else {
+      groupId = [Utils.getDayDate(recentCall.date),
+        '', recentCall.type];
+    }
     if (recentCall.status && recentCall.type === 'incoming') {
       groupId.push(recentCall.status);

Comment 7

[Wayne Chang [:wchang]]

Can we consider this for v1.2? - showing unknown numbers in call log.

Comment 8

[Joe Cheng [:jcheng] (please needinfo)]

triage: nice to have for v1.2, but really want to get this done in v1.3. 1.3+. please ask for approval for uplifting to v1.2 if needed

Comment 9

[David Scravaglieri [:scravag]]

This is a basic functionnality that is missing.

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

Attachment: Screenshot

Works for me with latest m-c/gaia